Closed Bug 1218858 Opened 7 years ago Closed 7 years ago

Update tracking protection language in about:privatebrowsing

Categories

(Firefox for Android Graveyard :: General, defect)

35 Branch
defect
Not set
normal

Tracking

(firefox43 verified, firefox44 verified)

VERIFIED FIXED
Firefox 44
Tracking Status
firefox43 --- verified
firefox44 --- verified

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(4 files)

Firefox blocks parts of the pages that may track your browsing activity.

"Firefox will prevent you from being tracked and won't remember any history, but downloaded files and new bookmarks will still be saved to your device."

...should be..

"Firefox blocks parts of the pages that may track your browsing activity."

Barbara, can you verify this is the only string that needs to be changed?

I can prepare a patch for uplift that only updates the content of the string, not the entity, to fix this in en-US only for 42. Flod, should we do the same thing for 43, or would it be okay to uplift an entity change this late in the Aurora cycle?
Flags: needinfo?(francesco.lodolo)
Flags: needinfo?(bbermes)
(In reply to :Margaret Leibovic from comment #0)
> Firefox blocks parts of the pages that may track your browsing activity.
> 
> "Firefox will prevent you from being tracked and won't remember any history,
> but downloaded files and new bookmarks will still be saved to your device."
> 
> ...should be..
> 
> "Firefox blocks parts of the pages that may track your browsing activity."

Actually, this new string should probably still talk about downloaded files and bookmarks, right? How about this?

"
Firefox blocks parts of the pages that may track your browsing activity.

Firefox won't remember any history, but downloaded files and new bookmarks will still be saved to your device.
"
Are we still talking about making the change in fx42? I thought this was moved for good to fx43 (and merge b-r was yesterday).

Some background on what happens when you change a string:
* If you update the string with a new ID, all locales will fall-back to English. That's horrible.
* If you update the string without a new ID, some locales won't even notice the change. For other people tools might still do it, and fall back to English marking the existing translations as fuzzy/obsolete. Still bad.

Pootle, a localization tool used by several locales, is normally hooked up only to mozilla-aurora, not Beta. But for fx42, being a special release, it's exposing also the Beta channel for localization.

My suggestion to minimize the mess would be to:
* Not touch fx42 at all. We're not even giving a chance to responsive locales to do anything (sign-off is closed)
* Land strings in mozilla-central with new IDs for fx44, and make sure they reach mozilla-aurora. Deadline for that is basically this week, so the sooner we do it the better.
* Update the strings on fx43 without changing string IDs when fx43 is in mozilla-beta. That would prevent potential issues with Pootle if we land string changes in mozilla-aurora this week.

It's far from optimal, but that's the only way I see to avoid showing untranslated content in a ton of locales, in a feature that will be promoted all over the place in the next weeks.

@Pike
Thoughts?
Flags: needinfo?(francesco.lodolo) → needinfo?(l10n)
What flod said.
Flags: needinfo?(l10n)
Attached image screenshot
I updated the sentence that relates to tracking protection to meet Elvin's request, and I used my best judgement to separate the rest of the message into a separate sentence, following patterns of the current language we use.

What do you think?
Attachment #8679690 - Flags: feedback?(alam)
Comment on attachment 8679684 [details] [diff] [review]
Patch for 44: Update tracking protection language in about:privatebrowsing

Review of attachment 8679684 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/locales/en-US/chrome/aboutPrivateBrowsing.dtd
@@ +16,5 @@
> +<!-- Localization note (privatebrowsingpage.title.privateStart, privatebrowsingpage.description.privateEnd):
> +	 These strings will appear in two paragraphs on new private tabs. -->
> +<!ENTITY privatebrowsingpage.description.privateStart "&brandShortName; blocks parts of the pages that may track your browsing activity.">
> +<!ENTITY privatebrowsingpage.description.privateEnd "We won't remember any history, but downloaded files and new bookmarks will still be saved to your device.">
> +

I wonder if there's a more semantic naming of these entities.

.overview and .details ?

The start and end indicate that there's a single sentence kind-of thing, aka, inline segments.

For block-level segments, I'd suggest to be specific about the intent.
Comment on attachment 8679690 [details]
screenshot

Thanks Margaret! this is getting quite long now. But it is a difficult position we're in. 

In the interim, I'll post my suggestion in this next comment too :)

Elvin, I'd love to get some more context here as to what specifically we need to avoid and what we need to say?  It'd really help us offer more solutions to help solve the core issue here.
Flags: needinfo?(ellee)
Attachment #8679690 - Flags: feedback?(alam) → feedback-
Attached image prev_pb_aboutpb2.png
As mentioned above ^, would this work?
Flags: needinfo?(margaret.leibovic)
I'm partial to attachment 8679752 [details] from Margaret's comment #6. The first half addresses Tracking Protection, and the second half addresses Private Browsing, and thus avoids conflating the two features.

The original request from Marshall was to conform to our Desktop language to avoid being overly declarative about the safety provided by tracking protection.
Flags: needinfo?(ellee)
Attachment #8679684 - Flags: review?(mark.finkle) → review+
Comment on attachment 8679687 [details] [diff] [review]
Patch for 43: Update tracking protection language in about:privatebrowsing (string change for en-US uplift only)

LGTM, but make sure Product and L10N are aware of this en-US only change, and have no problems with it.
Attachment #8679687 - Flags: review?(mark.finkle) → review+
(In reply to Mark Finkle (:mfinkle) from comment #11)
> Comment on attachment 8679687 [details] [diff] [review]
> Patch for 43: Update tracking protection language in about:privatebrowsing
> (string change for en-US uplift only)
> 
> LGTM, but make sure Product and L10N are aware of this en-US only change,
> and have no problems with it.

As explained above, it's fine as long as we wait to land this when fx43 is in mozilla-beta (next Tuesday).

I'll take care of sending an email to dev-l10n as soon as it happens.
Based on legal's comments, 43 would be ideal.

Thanks
Flags: needinfo?(bbermes)
(In reply to Anthony Lam (:antlam) from comment #9)
> Created attachment 8679752 [details]
> prev_pb_aboutpb2.png
> 
> As mentioned above ^, would this work?

This looks like it's effectively the same length, but seems more difficult to read. Do you agree?

I'll let you make the final call on what we do here, but I prefer the patch as-is.
Flags: needinfo?(margaret.leibovic) → needinfo?(alam)
(In reply to :Margaret Leibovic from comment #14)
> (In reply to Anthony Lam (:antlam) from comment #9)
> > Created attachment 8679752 [details]
> > prev_pb_aboutpb2.png
> > 
> > As mentioned above ^, would this work?
> 
> This looks like it's effectively the same length, but seems more difficult
> to read. Do you agree?
> 
> I'll let you make the final call on what we do here, but I prefer the patch
> as-is.

Sure, WFM. 

Thanks Margaret!
Flags: needinfo?(alam)
Comment on attachment 8679687 [details] [diff] [review]
Patch for 43: Update tracking protection language in about:privatebrowsing (string change for en-US uplift only)

Approval Request Comment
[Feature/regressing bug #]: Tracking protection in private browsing.

[User impact if declined]: Language in about:privatebrowsing isn't clear about what tracking protection does.

[Describe test coverage new/current, TreeHerder]: No tests, verified locally.

[Risks and why]: Low-risk string change.

[String/UUID change made/needed]: This is an en-US only change requested by our legal team. See previous comments from flod in this bug.
Attachment #8679687 - Flags: approval-mozilla-aurora?
Comment on attachment 8679687 [details] [diff] [review]
Patch for 43: Update tracking protection language in about:privatebrowsing (string change for en-US uplift only)

I just chatted with flod on IRC, and I misread his comment. We want to land this on 43, but we want to wait until 43 hits beta, to reduce churn for localizers.
Attachment #8679687 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/integration/fx-team/rev/0160ff5dfde28032fb5f752d81e72e1ffc964271
Bug 1218858 - Update tracking protection language in about:privatebrowsing. r=mfinkle
https://hg.mozilla.org/mozilla-central/rev/0160ff5dfde2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Comment on attachment 8679687 [details] [diff] [review]
Patch for 43: Update tracking protection language in about:privatebrowsing (string change for en-US uplift only)

Review of attachment 8679687 [details] [diff] [review]:
-----------------------------------------------------------------

Approval Request Comment
[Feature/regressing bug #]: Tracking protection in private browsing.

[User impact if declined]: Language in about:privatebrowsing isn't clear about what tracking protection does.

[Describe test coverage new/current, TreeHerder]: No tests, verified locally.

[Risks and why]: Low-risk string change.

[String/UUID change made/needed]: This is an en-US only change requested by our legal team. See previous comment 2 and comment 11 in this bug.
Attachment #8679687 - Flags: approval-mozilla-beta?
Comment on attachment 8679687 [details] [diff] [review]
Patch for 43: Update tracking protection language in about:privatebrowsing (string change for en-US uplift only)

Looks good for uplift to beta.
Attachment #8679687 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed on Firefox 43 Beta 2, on latest Aurora and Nightly
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.