Closed Bug 1218875 Opened 8 years ago Closed 8 years ago

class nsIDOMWindow has no member named OpenDialog

Categories

(MailNews Core :: Backend, defect)

Product:
MailNews Core
Component:
Backend
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 44.0

People

(Reporter: neil, Unassigned)

References

Details

(Keywords: dogfood, regression)

Attachments

(2 files)

Proposed patch
19.92 KB, patch
jcranmer
: review+
Details | Diff | Splinter Review
Bug1218875fix.patch
1.84 KB, patch
jcranmer
: review+
Details | Diff | Splinter Review 
Bug 1216401 moved all the methods to nsPIDOMWindow.
Attached patch Proposed patch — — Splinter Review 

        Attachment #8679528 -
        Flags: review?(Pidgeot18)

    
    

    
  
Comment on attachment 8679528 [details] [diff] [review]
Proposed patch

Review of attachment 8679528 [details] [diff] [review]:
-----------------------------------------------------------------

I'd ask about uses in JS, but the answer is that it's just the XPIDL that's being deletified, so they shouldn't be affected. rs=me.

        Attachment #8679528 -
        Flags: review?(Pidgeot18) → review+

    
    

    
  
Pushed comm-central changeset f213d36d9e16.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED

    
    

    
  
Still seeing
 
c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/mailnews/base/src/nsMessengerWinIntegration.cpp(127) : error C2039: 'Focus' : is not a member of 'nsIDOMWindow'

on Windows.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  


  
Ratty provided a patch in IRC. I tested it locally and it built successfully with it.

        Attachment #8679597 -
        Flags: review?(Pidgeot18)

    
    

    
  
Comment on attachment 8679597 [details] [diff] [review]
Bug1218875fix.patch

Review of attachment 8679597 [details] [diff] [review]:
-----------------------------------------------------------------

rs+

        Attachment #8679597 -
        Flags: review?(Pidgeot18) → review+

    
    

    
  
https://hg.mozilla.org/comm-central/rev/547e6754480eb5a30af54258dca1226972230858
Bug 1218875 - Fix the error in nsMessengerWinIntegration.cpp. r=jcranmer a=bustage fix on CLOSED TREE

    
  
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 44.0
Severity: normal → blocker
Keywords: dogfood, 
          
            regression

          You need to log in
          before you can comment on or make changes to this bug.