Closed
Bug 1218875
Opened 10 years ago
Closed 10 years ago
class nsIDOMWindow has no member named OpenDialog
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 44.0
People
(Reporter: neil, Unassigned)
References
Details
(Keywords: dogfood, regression)
Attachments
(2 files)
|
19.92 KB,
patch
|
jcranmer
:
review+
|
Details | Diff | Splinter Review |
|
1.84 KB,
patch
|
jcranmer
:
review+
|
Details | Diff | Splinter Review |
Bug 1216401 moved all the methods to nsPIDOMWindow.
|
Reporter | |
Comment 1•10 years ago
|
||
Attachment #8679528 -
Flags: review?(Pidgeot18)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8679528 [details] [diff] [review]
Proposed patch
Review of attachment 8679528 [details] [diff] [review]:
-----------------------------------------------------------------
I'd ask about uses in JS, but the answer is that it's just the XPIDL that's being deletified, so they shouldn't be affected. rs=me.
Attachment #8679528 -
Flags: review?(Pidgeot18) → review+
|
|
Reporter | |
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Comment 4•10 years ago
|
||
Still seeing
c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/mailnews/base/src/nsMessengerWinIntegration.cpp(127) : error C2039: 'Focus' : is not a member of 'nsIDOMWindow'
on Windows.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Comment 5•10 years ago
|
||
Ratty provided a patch in IRC. I tested it locally and it built successfully with it.
Attachment #8679597 -
Flags: review?(Pidgeot18)
|
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8679597 [details] [diff] [review]
Bug1218875fix.patch
Review of attachment 8679597 [details] [diff] [review]:
-----------------------------------------------------------------
rs+
Attachment #8679597 -
Flags: review?(Pidgeot18) → review+
|
|
||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/547e6754480eb5a30af54258dca1226972230858
Bug 1218875 - Fix the error in nsMessengerWinIntegration.cpp. r=jcranmer a=bustage fix on CLOSED TREE
|
|
||
Updated•10 years ago
|
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 44.0
|
||
Updated•10 years ago
|
Severity: normal → blocker
Keywords: dogfood,
regression
You need to log in
before you can comment on or make changes to this bug.
Description
•