class nsIDOMWindow has no member named OpenDialog

RESOLVED FIXED in Thunderbird 44.0

Status

defect
--
blocker
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: neil, Unassigned)

Tracking

({dogfood, regression})

unspecified
Thunderbird 44.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Reporter

Description

4 years ago
Bug 1216401 moved all the methods to nsPIDOMWindow.
Reporter

Comment 1

4 years ago
Attachment #8679528 - Flags: review?(Pidgeot18)
Comment on attachment 8679528 [details] [diff] [review]
Proposed patch

Review of attachment 8679528 [details] [diff] [review]:
-----------------------------------------------------------------

I'd ask about uses in JS, but the answer is that it's just the XPIDL that's being deletified, so they shouldn't be affected. rs=me.
Attachment #8679528 - Flags: review?(Pidgeot18) → review+
Reporter

Comment 3

4 years ago
Pushed comm-central changeset f213d36d9e16.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Comment 4

4 years ago
Still seeing
 
c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/mailnews/base/src/nsMessengerWinIntegration.cpp(127) : error C2039: 'Focus' : is not a member of 'nsIDOMWindow'

on Windows.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Ratty provided a patch in IRC. I tested it locally and it built successfully with it.
Attachment #8679597 - Flags: review?(Pidgeot18)
Comment on attachment 8679597 [details] [diff] [review]
Bug1218875fix.patch

Review of attachment 8679597 [details] [diff] [review]:
-----------------------------------------------------------------

rs+
Attachment #8679597 - Flags: review?(Pidgeot18) → review+

Comment 7

4 years ago
https://hg.mozilla.org/comm-central/rev/547e6754480eb5a30af54258dca1226972230858
Bug 1218875 - Fix the error in nsMessengerWinIntegration.cpp. r=jcranmer a=bustage fix on CLOSED TREE

Updated

4 years ago
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 44.0
Severity: normal → blocker
Keywords: dogfood, regression
You need to log in before you can comment on or make changes to this bug.