121899 - Change certain entity declarations in chrome://navigator/locale/pageInfo.dtd

Status: VERIFIED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Greg K.]

I suggest the following entity declarations be changed in pageInfo.dtd.

generalURL, from URL to URI
mediaWidth, from "W:" to "Width:"
mediaHeight, from "H:" to Height:"

Comment 1

[Daniel Brooks [:db48x]]

URL -> URI seems a little pendantic or something.

Also, would it be better to have the dimensions reported as widthxheight (600x50
or whatever)?

Comment 2

[Greg K.]

I suggest URI only because it's what the W3 uses now to refer to such things.
Not really a big deal, though, you're right.

As for dimensions, I'll suggest, "800 pixels wide by 600 high." Let's avoid the
"x", we're not that pressed for space here.

Comment 3

[Daniel Brooks [:db48x]]

Attachment: possible fix

Comment 4

[Greg K.]

What are those "--" strings? Should those be —?

Comment 5

[Daniel Brooks [:db48x]]

no, those are never shown. notice that they're commented out for now.

Comment 6

[Jesse Ruderman]

I think "Address:" would be better than "URL:" or "URI:".

Comment 7

[Daniel Brooks [:db48x]]

Attachment: different fix, one that is probably better.

Comment 8

[Christopher Hoess (gone)]

While you're messing with the DTD, "Related Link" would probably be a better
choice than "Relative Link"; what we normally call relative links have nothing
to do with the "rel" attribute.

Comment 9

[Daniel Brooks [:db48x]]

*** Bug 127332 has been marked as a duplicate of this bug. ***

Comment 10

[Daniel Brooks [:db48x]]

Attachment: duh. patch might be funky, but at least if it applies it will actually work.

thanks bz :)

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 74039 [details] [diff] [review]
duh. patch might be funky, but at least if it applies it will actually work.

r=bzbarsky

Comment 12

[Alec Flett]

Comment on attachment 74039 [details] [diff] [review]
duh. patch might be funky, but at least if it applies it will actually work.

sr=alecf

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 74039 [details] [diff] [review]
duh. patch might be funky, but at least if it applies it will actually work.

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 14

[Boris Zbarsky [:bzbarsky]]

checked in on the trunk