1219015 - chatzilla-service.js line 56: ReferenceError: reference to undefined property Components.interfaces.nsICmdLineHandler

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[Martin Mokrejs]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0 SeaMonkey/2.38
Build ID: 20151026022210

Steps to reproduce:

So far I used seamoneky-2.32, now after upgrade to 2.38 I get this logged:


Actual results:

++DOMWINDOW == 2 (0x7fd8fb882400) [pid = 4464] [serial = 2] [outer = 0x7fd8fc4cc800]
JavaScript strict warning: jar:file:///home/mmokrejs/.mozilla/seamonkey/mjpwg8sv.default/extensions/%7B59c81df5-4b7a-477b-912d-4e0fdf64e5f2%7D.xpi!/components/chatzilla-service.js, line 56: ReferenceError: reference to undefined property Components.interfaces.nsICmdLineHandler
JavaScript error: resource://gre/components/nsMailNewsCommandLineHandler.js, line 40: uncaught exception: 2147942487
++DOCSHELL 0x7fd8fd5c3a00 == 2 [pid = 4464] [id = 2]

Comment 1

[Tony Mechelynck [:tonymec]]

I wonder if this is a SeaMonkey (or Core or Toolkit or...) problem, or a ChatZilla problem.

Martin, which version of ChatZilla are you using? (You can find it for instance on the "ChatZilla" line under "Extensions" on the page opened by "Help → Troubleshooting Information".) The current "stable" version is 0.9.92.

Comment 2

[:Gijs (he/him)]

It's a strict error; pretty sure this is just because at some point nsICmdLineHandler got removed. The only mention in the tree is an implementation, the interface seems gone...

Comment 3

[Martin Mokrejs]

about:addons shows it is 0.9.92

Comment 4

[Rainer Bielefeld]

NOT reproducible with  en-US (German language pack) SeaMonkey 2.38  (Windows NT 6.1; WOW64; rv:41.0)  Gecko/20100101 Firefox/41.0 Build 20150923195647  (Classic Theme) on German WIN7 64bit, Chatzilla 0.9.92

But I get Chatzilla messages in Error console from time to time, for example

Fehler: An error occurred updating the cmd_newlist command: [Exception... "[JavaScript Error: "kAllDirectoryRoot is not defined" {file: "chrome://messenger/content/addressbook/abResultsPane.js" line: 423}]'[JavaScript Error: "kAllDirectoryRoot is not defined" {file: "chrome://messenger/content/addressbook/abResultsPane.js" line: 423}]' when calling method: [nsIController::isCommandEnabled]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://global/content/globalOverlay.js :: goUpdateCommand :: line 80"  data: yes]
Quelldatei: chrome://global/content/globalOverlay.js
Zeile: 85

or

Warning: mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create
Source File: chrome://chatzilla/content/commands.js
Line: 333

But not reproducible at all.

@Martin Mokrejs:
Do you have real problems when using Chatzilla or do you only see error messages (error console or where ever)

Comment 5

[Martin Mokrejs]

(In reply to Rainer Bielefeld from comment #4)
> Do you have real problems when using Chatzilla or do you only see error
> messages (error console or where ever)

I do not use chatzilla (broser+mailer only) so the message on STDERR I can ignore. However, it is difficult to get through all the messages and ignore some selectively, and I will forget this particular case in a few days. Fix it or drop it from the tree.

Comment 7

[:Gijs (he/him)]

This interface was removed in bug 380786, which was basically the Firefox 4 / SM 2 timeframe, AFAICT. We should just drop all the code that references it.

Comment 8

[:Gijs (he/him)]

Attachment: remove references to nsICmdLineHandler,

Comment 9

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/chatzilla/rev/4cbd1ca53ffa

Comment 10

[Tony Mechelynck [:tonymec]]

Only by looking at the patch code do I understand what this means in practice:

There goes the only really easy way to have Firefox open a chatZilla window at startup (by invoking "firefox -chat"). I haven't yet tried to found out if the workaround "firefox -url irc://" works but I expect it does. Which newbie would guess it though? And they say they want to make Firefox easy to use? Ah la la.

In SeaMonkey it is of course still possible, either by selecting "Edit → Preferences → Appearance → When SeaMonkey starts up, open → [√] ChatZilla" at any time before the previous closedown (possibly in a different session), or by making sure (while SeaMonkey is not running) that its prefs.js contains the line
    user_pref("general.startup.chat", true);

There is still one (almost) obvious way to start cZ in a _running_ Firefox, of course: have the cZ button customized on a toolbar, and click it. (SeaMonkey has a handy cZ button on its statusbar and a "Window → IRC Chat" menuitem.)

Morality: When will those Firefox guys stop throwing sticks across the steps of anyone extending them a helping hand (or, if you prefer a more mechanistic metaphor, wrenches into the cogs of anyone trying to work with them)? With too much paranoia what you get rid of is not exploitation (there'll always be scammers who'll successfully rip off the most paranoid tycoon or Mafia boss), it's goodwill.

I just checked that the "-chat" command-line switch does not appear in the result of "seamonkey -h" in the 20160101 nightly of SeaMonkey 2.43a1 (where I went to the trouble of reinstalling cZ from <appdir>/distribution/extensions/{59*.xpi ).

@Martin Mokrejs: Do you still see these errors after upgrading to the latest ChatZilla nightly, found at http://james-ross.co.uk/mozilla/chatzilla/nightly/builds/0.9.92/2015122917/chatzilla-0.9.92-2015122917.xpi ? If you don't, you may mark this bug VERIFIED.

Comment 11

[:Gijs (he/him)]

(In reply to Tony Mechelynck [:tonymec] from comment #10)
> Only by looking at the patch code do I understand what this means in
> practice:
> 
> There goes the only really easy way to have Firefox open a chatZilla window
> at startup (by invoking "firefox -chat"). I haven't yet tried to found out
> if the workaround "firefox -url irc://" works but I expect it does. Which
> newbie would guess it though? And they say they want to make Firefox easy to
> use? Ah la la.

Did you actually verify this no longer works, and indeed, that it worked before this patch landed? This interface hasn't been implemented for years now, see comment #7, and was replaced by other ones. I did not intend to remove anything that worked in this patch. If I did, more details would be great.

> Morality: When will those Firefox guys stop throwing sticks across the steps
> of anyone extending them a helping hand (or, if you prefer a more
> mechanistic metaphor, wrenches into the cogs of anyone trying to work with
> them)? With too much paranoia what you get rid of is not exploitation
> (there'll always be scammers who'll successfully rip off the most paranoid
> tycoon or Mafia boss), it's goodwill.

I don't really understand this statement, but as a "Firefox guy" it's a little offensive, Tony. :-\

Comment 12

[Tony Mechelynck [:tonymec]]

(In reply to :Gijs Kruitbosch from comment #11)
> (In reply to Tony Mechelynck [:tonymec] from comment #10)
> > Only by looking at the patch code do I understand what this means in
> > practice:
> > 
> > There goes the only really easy way to have Firefox open a chatZilla window
> > at startup (by invoking "firefox -chat"). I haven't yet tried to found out
> > if the workaround "firefox -url irc://" works but I expect it does. Which
> > newbie would guess it though? And they say they want to make Firefox easy to
> > use? Ah la la.
> 
> Did you actually verify this no longer works, and indeed, that it worked
> before this patch landed? This interface hasn't been implemented for years
> now, see comment #7, and was replaced by other ones. I did not intend to
> remove anything that worked in this patch. If I did, more details would be
> great.

I have in the past used "firefox -chat" to start Firefox with ChatZilla; but I hadn't verified that it had stopped working. After having seen the patch, I am surprised to see that in the following build it still works, even after installing the latest ChatZilla nightly, linked at the bottom of the post.
> 
> > Morality: When will those Firefox guys stop throwing sticks across the steps
> > of anyone extending them a helping hand (or, if you prefer a more
> > mechanistic metaphor, wrenches into the cogs of anyone trying to work with
> > them)? With too much paranoia what you get rid of is not exploitation
> > (there'll always be scammers who'll successfully rip off the most paranoid
> > tycoon or Mafia boss), it's goodwill.
> 
> I don't really understand this statement, but as a "Firefox guy" it's a
> little offensive, Tony. :-\

Hm, maybe I got a little excited, not just by this, but by a lot of little other things too, not the least of which is the current official policy of MoCo making it illegal for any MoCo employee to even raise the little finger to help comm-central on company time. But since my main argument falls flat on its face I'll fold away the comment you quoted.

And BTW, I think of you more as a "ChatZilla guy" than as a "Firefox guy" and my beloved SeaMonkey wouldn't be SeaMonkey without ChatZilla. Similarly, when I come across Neil's or Callek's names in the list of Firefox, Core and Toolkit owners and peers it doesn't make me think less of them, whom I know primarily as "SeaMonkey guys".

Comment 13

[Tony Mechelynck [:tonymec]]

P.S. I forgot to mention in which build I had tested it recently:
UA:"Mozilla/5.0 (X11; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0" (en-US) ID:20160104030217 CSet:0771c5eab32f0cee4f7d12bc382298a81e0eabb2
and with the latest cZ nightly installed.

Comment 14

[Tony Mechelynck [:tonymec]]

Only the last paragraph of my folded-out comment remains valid: as follows:

@Martin Mokrejs: Do you still see these errors after upgrading to the latest ChatZilla nightly, found at http://james-ross.co.uk/mozilla/chatzilla/nightly/builds/0.9.92/2015122917/chatzilla-0.9.92-2015122917.xpi ? If you don't, you may mark this bug VERIFIED.

(setting needinfo?)

Comment 15

[Martin Mokrejs]

(In reply to Tony Mechelynck [:tonymec] from comment #14)
> Only the last paragraph of my folded-out comment remains valid: as follows:
> 
> @Martin Mokrejs: Do you still see these errors after upgrading to the latest
> ChatZilla nightly, found at
> http://james-ross.co.uk/mozilla/chatzilla/nightly/builds/0.9.92/2015122917/
> chatzilla-0.9.92-2015122917.xpi ? If you don't, you may mark this bug
> VERIFIED.
> 
> (setting needinfo?)

Sorry, what am I supposed to do with the file? Anyway, I cannot download it: bug #1236833

Comment 16

[Tony Mechelynck [:tonymec]]

(In reply to Martin Mokrejs from comment #15)
> (In reply to Tony Mechelynck [:tonymec] from comment #14)
> > Only the last paragraph of my folded-out comment remains valid: as follows:
> > 
> > @Martin Mokrejs: Do you still see these errors after upgrading to the latest
> > ChatZilla nightly, found at
> > http://james-ross.co.uk/mozilla/chatzilla/nightly/builds/0.9.92/2015122917/
> > chatzilla-0.9.92-2015122917.xpi ? If you don't, you may mark this bug
> > VERIFIED.
> > 
> > (setting needinfo?)
> 
> Sorry, what am I supposed to do with the file? Anyway, I cannot download it:
> bug #1236833

1. Download to your HD:
1.1. RIGHT click the link
1.2. Save Link Target As…
---- (a file chooser appears)
1.3. Select some convenient directory, then [Save]
2. Install:
2.1. Open the Add-ons Manager
2.2. Near the top, unroll the rolldown widget
2.3. Install Add-on From File…
---- (a file chooser appears)
2.4. Go back to the same directory as in 1.3. above, then double-click the newly downloaded XPI.
---- (an are-you-sure popup appears, with an Install button which is first greyed-out, but becomes usable after a few seconds)
2.5. [Install Now]
---- (When the download is complete and as much of the installation done as can be done without restarting, you get a doorhanger: "ChatZilla will be updated after you restart SeaMonkey"
2.6. (when you are ready) Hit Ctrl-Q
3. Restart with a fresh log:
seamonkey > ~/test-bug1219015.log 2>&1
4. Go on using SeaMonkey until you know that if the error in comment #0 still happens, it will have happened by now.
5. Quit (Ctrl+Q)
6. Wait until "ps -lC seamonkey" answers with only column headings.
7. Open ~/test-bug1219015.log in your favourite plaintext editor and search its text for the entry found in comment #0.
8. If not found → SUCCESS → VERIFIED.

Comment 17

[Martin Mokrejs]

Hi Tony,
  I am sorry for the ridiculous delay ... I started official 2.39 build binary from /usr/local/seamonkey and did the update of chatzilla using the XPI file. Therefore I assume chatzilla was updated under my ~/.mozilla/seamonkey. Addons-manager shows it was updated today. Unfortunately, "About Chatzilla" window still shows 0.9.92 (would be nice if nightly builds had some special version number instead). However, I do not see any messages logged in the logfile so I will close this as VERIFIED.


If I try to run my site-wide seamonkey it probably always picks preferentially chatzilla from site-wide /usr/lib/seamonkey directory and ignores the update from ~/.mozilla/seamonkey. So, that system-wide seamonkey still emits this Javascript error but if it really ignores the addon in my ~/.mozilla/seamonkey then this does not prove anything else than that a sytem-wide provided old chatzilla wins over the users' specific version.


Isn't the Javascript error reported only in debug-enabled builds? If yes it would mean I will never the message logged from the official seamonkey-2.39.en-US.linux-x86_64.tar.bz2 binaries (Nov 11 2015 21:25) even with a broken chatzilla ...

Comment 18

[Tony Mechelynck [:tonymec]]

In reply to comment #17:
If you install the ChatZilla XPI from the latest subdirectory of http://james-ross.co.uk/mozilla/chatzilla/nightly/builds/0.9.92/ you will see its datestamp after 0.9.92 as part of its version string in the ChatZilla client tab, in the add-ons manager details pane, and on mouseover in the add-ons manager list pane, showing that add-ons you installed yourself take precedence over what came with SeaMonkey. (This "visible datestamp" feature is a result of the fix for bug 1242269.)

In addition, the fact that Chatzilla comes bundled in the /distribution/extensions/ subdirectory of the installation directory (and not in extensions/) means that, when checking extension versions when a change of SeaMonkey version is noticed, the ChatZilla that comes bundled with the new version will be installed in your profile, but *only* if there isn't already a higher cZ version in that profile. Since 0.9.92.2016021216 is "higher" than just 0.9.92, the nightly will remain until such time as a 0.9.93 (or 0.10 or 1.0) is published, something which hasn't yet happened.

Comment 19

[Martin Mokrejs]

Please REOPEN, I still see

JavaScript error: resource://gre/components/nsMailNewsCommandLineHandler.js, line 41: uncaught exception: 2147942487

even with chatzilla-0.9.92-2016021216.xpi from http://james-ross.co.uk/mozilla/chatzilla/nightly/builds/0.9.92/

Comment 20

[:Gijs (he/him)]

(In reply to Martin Mokrejs from comment #19)
> Please REOPEN, I still see
> 
> JavaScript error: resource://gre/components/nsMailNewsCommandLineHandler.js,
> line 41: uncaught exception: 2147942487
> 
> even with chatzilla-0.9.92-2016021216.xpi from
> http://james-ross.co.uk/mozilla/chatzilla/nightly/builds/0.9.92/

That's nsMailNewsCommandLineHandler.js, as it says in the error message, which isn't a chatzilla file. I fixed the first part of your error message in comment 0:

JavaScript strict warning: jar:file:///home/mmokrejs/.mozilla/seamonkey/mjpwg8sv.default/extensions/%7B59c81df5-4b7a-477b-912d-4e0fdf64e5f2%7D.xpi!/components/chatzilla-service.js, line 56: ReferenceError: reference to undefined property Components.interfaces.nsICmdLineHandler

but not the other part - you should file a mail/news bug for that.

Comment 21

[Martin Mokrejs]

So I opened bug #1249963 without any clue what I am reporting, sigh. Thank you anyway for the note.