1219067 - Support library annotations do not appear to work in IntelliJ

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I tried to use both the @NonNull and @WorkerThread annotations in BrowserApp and IntelliJ does not give warnings when the annotation recipients are misused. See [1] for an example where a warning should be given, but one I could not trigger.

Note: it's possible my configuration is messed up. I also vaguely remember this working in the past, though maybe I only verified the compilation worked correctly.

[1]: http://robusttechhouse.com/tutorial-how-to-use-android-support-annotations-library/

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #0)
> See [1] for an example

Specifically, section 2.3.

Comment 2

[Nick Alexander :nalexander [he/him]]

mcomella: I dug into this a little.  The annotation support is baked in the IDE, but I don't understand the method.  AS 1.4 just works.  IJ 14.1.5 does not have support for this.  

In more detail, both IDEs support the Android "Constant and Resource Type Mismatches" inspection.  That inspection has been upgraded to support @WorkerThread and friends in AS 1.4 and not in IJ 14.x.  Presumably it'll be eventually available in IJ, but I don't know when or how this area works.  It's worth noting that IJ does support lots of Android annotations, just not the new ones.

In the meantime, you can use it and the linter should still warn; or we can try using AS more.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

fwiw, the official article on the support library annotations implies it already just works:
  http://tools.android.com/tech-docs/support-annotations

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to Michael Comella (:mcomella) from comment #3)
> fwiw, the official article on the support library annotations implies it
> already just works:
>   http://tools.android.com/tech-docs/support-annotations

mcomella: I expect this to work in IJ 15, which claims to have the new features in AS 1.3.  I have no timetable for IJ 15 support but would appreciate early testers.  (It should Just Work but one Never Knows.)

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.