Closed
Bug 1219071
Opened 9 years ago
Closed 9 years ago
Cache the results of the dfs when rendering the tree widget
Categories
(DevTools :: Memory, defect)
DevTools
Memory
Tracking
(firefox44 fixed)
RESOLVED
FIXED
Firefox 44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file)
|
4.70 KB,
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
Probably not 100% essential to the 44 release, but def nice to have with large allocation stack breakdown report trees.
Right now we do a DFS to list tree items to find which items are in the viewport and only render those items. This DFS is still O(n) though, and it would be nice to cache it and get the rendering to O(1).
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8679870 -
Flags: review?(jsantell)
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8679870 [details] [diff] [review]
Cache the results of the dfs when rendering the tree widget
Review of attachment 8679870 [details] [diff] [review]:
-----------------------------------------------------------------
nice
Attachment #8679870 -
Flags: review?(jsantell) → review+
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•