Closed Bug 1219073 Opened 8 years ago Closed 8 years ago

Source location in heap tree should style/function like performance call tree

Categories

(DevTools :: Memory, defect)

Product:
DevTools
Component:
Memory
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox44 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: fitzgen, Assigned: jsantell)

References

Details

Attachments

(2 files)

1219073-sdk.patch
6.26 KB, patch
irakli
: review+
Details | Diff | Splinter Review
1219073-pt2.patch
12.24 KB, patch
fitzgen
: review+
Details | Diff | Splinter Review 
Right now it is plain text. Should be a link to view the line in the debugger.
* Should link to debugger
* Be styled like performance call tree
* Full path on hover
* Just show filename
Summary: source location in "allocation stack" breakdown's tree items should link to source in the debugger → Source location in heap tree should style/function like performance call tree
Assignee: nobody → jsantell
Status: NEW → ASSIGNED

        Attachment #8680152 -
        Flags: review?(rFobic)

        Attachment #8680152 -
        Flags: review?(rFobic) → review+

    
    

    
  


  
This'll need a test too

        Attachment #8680202 -
        Flags: review?(nfitzgerald)

    
    

    
  
Comment on attachment 8680202 [details] [diff] [review]
1219073-pt2.patch

Review of attachment 8680202 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/memory/app.js
@@ +29,5 @@
>    getChildContext() {
>      return {
>        front: this.props.front,
>        heapWorker: this.props.heapWorker,
> +      toolbox: this.props.toolbox,

File a follow up to have an `onOpenSourceLink` or whatever method instead of passing the toolbox in directly, as we talked about in person.

        Attachment #8680202 -
        Flags: review?(nfitzgerald) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/96b588073732
https://hg.mozilla.org/mozilla-central/rev/80a91d10efd8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago

          status-firefox44:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.