1219073 - Source location in heap tree should style/function like performance call tree

Status: RESOLVED FIXED

(DevTools :: Memory, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Right now it is plain text. Should be a link to view the line in the debugger.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

* Should link to debugger
* Be styled like performance call tree
* Full path on hover
* Just show filename

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1219073-sdk.patch

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/96b588073732

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1219073-pt2.patch

This'll need a test too

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8680202 [details] [diff] [review]
1219073-pt2.patch

Review of attachment 8680202 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/memory/app.js
@@ +29,5 @@
>    getChildContext() {
>      return {
>        front: this.props.front,
>        heapWorker: this.props.heapWorker,
> +      toolbox: this.props.toolbox,

File a follow up to have an `onOpenSourceLink` or whatever method instead of passing the toolbox in directly, as we talked about in person.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/80a91d10efd8

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/96b588073732
https://hg.mozilla.org/mozilla-central/rev/80a91d10efd8