1219082 - [mach try] AttributeError: 'AutoTry' object has no attribute 'resolver_func'

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Gerald Squelart [:gerald] (he/him)]

> ./mach try --no-push -b do -p all dom/media/test

gives the following output:

> mach try is under development, please file bugs blocking 1149670.
> From _tests: Kept 41643 existing; Added/updated 0; Removed 0 files and 0 directories.
> Error running mach:
> 
>     ['try', '--no-push', '-b', 'do', '-p', 'all', 'dom/media/test']
> 
> The error occurred in code that was called by the mach command. This is either
> a bug in the called code itself or in the way that mach is calling it.
> 
> You should consider filing a bug for this issue.
> 
> If filing a bug, please include the full output of mach, including this error
> message.
> 
> The details of the failure are as follows:
> 
> AttributeError: 'AutoTry' object has no attribute 'resolver_func'
> 
>   File "testing/mach_commands.py", line 639, in autotry
>     paths_by_flavor = at.paths_by_flavor(paths=paths, tags=tags)
>   File "testing/tools/autotry/autotry.py", line 251, in paths_by_flavor
>     tests = list(self.resolver.resolve_tests(paths=paths,
>   File "testing/tools/autotry/autotry.py", line 188, in resolver
>     self._resolver = self.resolver_func

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1219082 - Fix reference to "resolver_func" in mach try. r=jgraham

Bug 1219082 - Fix reference to "resolver_func" in mach try. r=jgraham

Comment 2

[Gerald Squelart [:gerald] (he/him)]

Wow, super quick!
I've tried your fix locally and it did the trick splendidly, thank you.

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8679764 [details]
MozReview Request: Bug 1219082 - Fix reference to "resolver_func" in mach try. r=jgraham

https://reviewboard.mozilla.org/r/23527/#review20973

Oh wow.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a161ee010607

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a161ee010607