1219118 - [Taskcluster] Disable all ics tests on m-c and integration branches

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Edgar Chen [:edgar]]

Since we all agree leave ICS on in BuildBot and focus on stabilizing emu-x86-kk test on taskcluster [1], I am wondering could we just disable all ics test on taskcluster, which can save resources on b2gtest-emulator workerType and also helps bug 1215766.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1209180#c7

Comment 1

[Edgar Chen [:edgar]]

Attachment: WIP, Patch, v1

Comment 2

[Greg Arndt [:garndt]]

I'm not the owner of what should get tested for each product, but I know that at one point there were those that thought ICS was a platform we should be testing on.

I'm also including tzimmermann in on this because I think he has been working on the ICS emulator build/tests to get them running better.

As far as the attached patch specifically, I think that would do the trick.

Comment 3

[Edgar Chen [:edgar]]

(In reply to Greg Arndt [:garndt] from comment #2)
> I'm not the owner of what should get tested for each product, but I know
> that at one point there were those that thought ICS was a platform we should
> be testing on.
> 
> I'm also including tzimmermann in on this because I think he has been
> working on the ICS emulator build/tests to get them running better.
> 
> As far as the attached patch specifically, I think that would do the trick.

ICS will still be enabled on the buildbot until we get a stable tests (on either emu-ics or emu-x86-kk) on TC. And for TC, IMO we could just skip emu-ics tests and focus on emu-x86-kk given that emu-ics tests will be deprecated eventually after migrating to emu-x86-kk.

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Edgar Chen [:edgar][:echen] from comment #3)
> (In reply to Greg Arndt [:garndt] from comment #2)
> > I'm not the owner of what should get tested for each product, but I know
> > that at one point there were those that thought ICS was a platform we should
> > be testing on.
> > 
> > I'm also including tzimmermann in on this because I think he has been
> > working on the ICS emulator build/tests to get them running better.
> > 
> > As far as the attached patch specifically, I think that would do the trick.
> 
> ICS will still be enabled on the buildbot until we get a stable tests (on
> either emu-ics or emu-x86-kk) on TC. And for TC, IMO we could just skip
> emu-ics tests and focus on emu-x86-kk given that emu-ics tests will be
> deprecated eventually after migrating to emu-x86-kk.

Kind information: Edgar's comment is actually the conclusion in a previous discussion [1]. I didn't see something might change the consensus.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1209180#c8

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Nothing to add from my side.

Comment 6

[Greg Arndt [:garndt]]

Comment on attachment 8679851 [details] [diff] [review]
WIP, Patch, v1

Based on the comment in the other bug and in the comments here, it appears that ICS tests are not stable nor needed on TC right now.  They will continue running in buildbot and we will be working towards creating stable tests for x86 emulator on TC

Comment 7

[Greg Arndt [:garndt]]

Just be aware that depending on timing, bug 1218919 might affect landing of this patch because they are both touching the base jobs file. (touching different parts but should be ok).

Comment 8

[Edgar Chen [:edgar]]

(In reply to Greg Arndt [:garndt] from comment #7)
> Just be aware that depending on timing, bug 1218919 might affect landing of
> this patch because they are both touching the base jobs file. (touching
> different parts but should be ok).

I will wait for bug 1218919 to land first and do rebase. Thank you.

Comment 9

[Edgar Chen [:edgar]]

Attachment: Patch, v2, r=garndt

Carry r=garndt and rebase over bug 1218919.

Comment 10

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a9772e297c9&group_state=expanded

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/f23d62756251

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f23d62756251

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/f23d62756251

Comment 14

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion