1219152 - [meta] Add unit tests for ESLint custom rules

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Patrick Brosset <:pbro>]

We've started creating custom ESLint rules for our code base (bug 1218425, bug 1218409, bug 1168338, bug 1218412), so it's time we also add unit tests for those.

Rules should be very easy to test, they're really the sort of things that unit tests are good for: just feed them a series of text inputs, and expect the output to either be valid, or invalid with a list of expected error messages.

It should be possible to write xpcshell tests for them.

For info, default eslint rules are all unit tested, see http://eslint.org/docs/developer-guide/working-with-rules#rule-unit-tests

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Default rules are tested by running them against a string and checking the output. Some of our rules are actually behaviors so there is no output making testing far more difficult.

We should certainly investigate how we can do this though.

Comment 2

[Mark Banner (:standard8)]

We've now got a variety of tests for the custom rules, plus builders running in automation.

Whilst there's a few rules that haven't yet got tests, I think it is good enough to call this bug fixed.