Closed Bug 1219192 Opened 9 years ago Closed 7 years ago

[Messages] Use "beforeinput" and "input" instead of "keypress", "keydown", "keyup" when it's ready

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: julienw, Unassigned)

References

Details

We use "keypress", "keydown", "keyup" in several places. We should replace them by "input" and "beforeinput" where applicable. Note that "beforeinput" does not seem to be implemented by Gecko yet.

Current uses:

  views/conversation/js/compose.js:      // Trigger a recompute of size on the keypress events.
  views/conversation/js/compose.js:      // we need to bind to keydown & keypress because of #870120
  views/conversation/js/compose.js:      dom.message.addEventListener('keydown', composeKeyEvents);
  views/conversation/js/compose.js:      dom.message.addEventListener('keypress', composeKeyEvents);
  views/conversation/js/conversation.js:      'keypress',
  views/conversation/js/recipients.js:    ['click', 'keypress', 'keyup', 'blur', 'pan'].forEach(function(type) {
  views/conversation/js/recipients.js:    if (event.type === 'keypress' || event.type === 'keyup') {
  views/conversation/js/recipients.js:      case 'keyup':
  views/conversation/js/recipients.js:      case 'keypress':
  views/conversation/js/recipients.js:              // Remove the placeholder that received the "keypress"
  views/conversation/js/subject_composer.js:    priv.input.addEventListener('keydown', onKeyDown.bind(this));
  views/conversation/js/subject_composer.js:    priv.input.addEventListener('keyup', onKeyUp.bind(this));
Mass closing of Gaia::SMS bugs. End of an era :(
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Mass closing of Gaia::SMS bugs. End of an era :(
You need to log in before you can comment on or make changes to this bug.