Closed
Bug 1219210
Opened 9 years ago
Closed 9 years ago
[B2G] Support proprietary YUV formats in GrallocImage and GrallocTextureClientOGL
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla45
People
(Reporter: jhlin, Assigned: sotaro)
References
Details
Attachments
(2 files, 6 obsolete files)
9.71 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
8.16 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•9 years ago
|
||
Follow up bug for bug 1099809 comment 56.
HW codecs usually use proprietary YUV pixel formats in graphic buffers. Support more formats in GrallocImage and GrallocTextureClientOGL seems helpful to video encoding/decoding cases.
Summary: [B2GSupport → [B2G] Support proprietary YUV formats in GrallocImage and GrallocTextureClientOGL
Reporter | ||
Updated•9 years ago
|
OS: Unspecified → Gonk (Firefox OS)
Assignee | ||
Comment 2•9 years ago
|
||
(In reply to John Lin [:jolin][:jhlin] from comment #1)
> Follow up bug for bug 1099809 comment 56.
It seems like Bug 1199809 comment 56.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Comment 4•9 years ago
|
||
Assignee | ||
Comment 5•9 years ago
|
||
attachment 8692837 [details] [diff] [review] tries to keep same buffer size between original buffer and copied buffer.
Assignee | ||
Updated•9 years ago
|
Attachment #8692836 -
Flags: review?(nical.bugzilla)
Assignee | ||
Updated•9 years ago
|
Attachment #8692837 -
Flags: review?(nical.bugzilla)
Attachment #8692837 -
Flags: review?(jolin)
Reporter | ||
Comment 6•9 years ago
|
||
Comment on attachment 8692836 [details] [diff] [review]
patch part 1 - Add ITextureClientAllocationHelper
Review of attachment 8692836 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/layers/client/TextureClientRecycleAllocator.cpp
@@ +130,4 @@
> // TextureAllocationFlags is actually used only by ContentClient.
> // This class does not handle ConteClient's TextureClient allocation.
> + MOZ_ASSERT(aHelper.mAllocFlags == TextureAllocationFlags::ALLOC_DEFAULT ||
> + aHelper.mAllocFlags == TextureAllocationFlags::ALLOC_DISALLOW_BUFFERTEXTURECLIENT);
aHelper.mAllocationFlags
@@ +130,5 @@
> // TextureAllocationFlags is actually used only by ContentClient.
> // This class does not handle ConteClient's TextureClient allocation.
> + MOZ_ASSERT(aHelper.mAllocFlags == TextureAllocationFlags::ALLOC_DEFAULT ||
> + aHelper.mAllocFlags == TextureAllocationFlags::ALLOC_DISALLOW_BUFFERTEXTURECLIENT);
> + MOZ_ASSERT(aTextureFlags & TextureFlags::RECYCLE);
aHelper.mTextureFlags
Reporter | ||
Comment 7•9 years ago
|
||
Comment on attachment 8692837 [details] [diff] [review]
patch part 2 - Add copy of VENUS color format
Review of attachment 8692837 [details] [diff] [review]:
-----------------------------------------------------------------
Great job. Thanks a lot!
Attachment #8692837 -
Flags: review?(jolin) → review-
Reporter | ||
Updated•9 years ago
|
Attachment #8692837 -
Flags: review- → review+
Updated•9 years ago
|
Attachment #8692837 -
Flags: review?(nical.bugzilla) → review+
Updated•9 years ago
|
Attachment #8692836 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 8•9 years ago
|
||
(In reply to John Lin [:jolin][:jhlin] from comment #6)
> Comment on attachment 8692836 [details] [diff] [review]
> patch part 1 - Add ITextureClientAllocationHelper
>
> Review of attachment 8692836 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: gfx/layers/client/TextureClientRecycleAllocator.cpp
> @@ +130,4 @@
> > // TextureAllocationFlags is actually used only by ContentClient.
> > // This class does not handle ConteClient's TextureClient allocation.
> > + MOZ_ASSERT(aHelper.mAllocFlags == TextureAllocationFlags::ALLOC_DEFAULT ||
> > + aHelper.mAllocFlags == TextureAllocationFlags::ALLOC_DISALLOW_BUFFERTEXTURECLIENT);
>
> aHelper.mAllocationFlags
>
> @@ +130,5 @@
> > // TextureAllocationFlags is actually used only by ContentClient.
> > // This class does not handle ConteClient's TextureClient allocation.
> > + MOZ_ASSERT(aHelper.mAllocFlags == TextureAllocationFlags::ALLOC_DEFAULT ||
> > + aHelper.mAllocFlags == TextureAllocationFlags::ALLOC_DISALLOW_BUFFERTEXTURECLIENT);
> > + MOZ_ASSERT(aTextureFlags & TextureFlags::RECYCLE);
>
> aHelper.mTextureFlags
Thanks! I'll update in a next patch.
Assignee | ||
Comment 9•9 years ago
|
||
Apply the comments. Carry "r=nical".
Attachment #8692836 -
Attachment is obsolete: true
Attachment #8695619 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Attachment #8695622 -
Flags: review+
Assignee | ||
Comment 11•9 years ago
|
||
Rebased. Carry "r=nical".
Attachment #8695622 -
Attachment is obsolete: true
Attachment #8695634 -
Flags: review+
Assignee | ||
Comment 12•9 years ago
|
||
Address windows problem.
Attachment #8695634 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Attachment #8695726 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Attachment #8695735 -
Flags: review+
Assignee | ||
Comment 14•9 years ago
|
||
Update nits.
Attachment #8695726 -
Attachment is obsolete: true
Attachment #8695737 -
Flags: review+
Assignee | ||
Comment 15•9 years ago
|
||
Comment 16•9 years ago
|
||
Comment 17•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•