1219228 - Disabling WEBRTC causes build break on Android build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Makoto Kato [:m_kato]]

This changeset is incorrect.

http://hg.mozilla.org/integration/mozilla-inbound/rev/92d510a09a8c

changeset:   162889:92d510a09a8c
user:        Mike Shal <[e-mail]>
date:        Thu Jan 09 14:43:29 2014 -0500
summary:     Bug 875013 - Remove VPATH in media/libvpx; r=joey

This fix has the following.

SOURCES += [
  '%s/sources/android/cpufeatures/cpu-features.c' % CONFIG['ANDROID_NDK'],
]

But this means,

CSRCS += $TOPSRCDIR/$ANDROID_NDK/sources/...

So this path is invalid.

Comment 1

[Mike Hommey [:glandium]]

Actually, that changeset was probably correct when it landed. But in the meantime, SOURCES semantics changed.

Comment 2

[Mike Hommey [:glandium]]

Specifically, adding '%%'  at the beginning of that path should fix it (double % because of the formatting, so that the end result starts with a literal %, which now means absolute path).

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Mike Hommey [:glandium] from comment #2)
> Specifically, adding '%%'  at the beginning of that path should fix it
> (double % because of the formatting, so that the end result starts with a
> literal %, which now means absolute path).

The path of cpu-features.c isn't into source directory and objdir directory, so it hits an assertion by "assert isinstance(f, ObjDirPath)" into emit.py.

Comment 5

[Mike Hommey [:glandium]]

Change it to be isinstance(f, Path)

Comment 6

[Makoto Kato [:m_kato]]

Attachment: Generate correct source path of cpu-features.c

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf640d7a8d02

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cf640d7a8d02

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/cf640d7a8d02