Closed Bug 121925 Opened 22 years ago Closed 22 years ago

nsDependentCString assertions

Categories

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Product:
Other Applications Graveyard
Component:
Venkman JS Debugger
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.0

People

(Reporter: rginda, Assigned: rginda)

Details

Attachments

(1 file, 1 obsolete file)

correct patch
3.38 KB, patch
Details | Diff | Splinter Review 
Some (all?) of the |string|s in jsdIDebuggerService.idl should probably be
migrated to const AStrings to save copying and convoluted code.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
I think the problem I was worried about here was the slew of

###!!! ASSERTION: nsDependentCString must wrap a non-NULL buffer: 'aPtr', file
../../dist/include/string/nsDependentString.h, line 128

assertions the debugger caused.  Patch coming up that avoids these assertions by
not attempting to wrap a null string.
Attached patch patch, round one (obsolete) — — Splinter Review 

    
    

    
  
small patch looking for review for 1.0.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        correct patch
        — 
          — Splinter Review
      

    


  
last patch is for another bug, please ignore.

        Attachment #70703 -
        Attachment is obsolete: true

    
  
Summary: string usage in debugger service idl → nsDependentCString assertions

    
    

    
  
Looks okay to me, but feel free to use PL_strdup instead of
ToNewCString(nsDependentCString(...)). If you already know the length of the
string, you'll want to use PL_strndup instead.

    
    

    
  
fix went is with bug 109652
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Product: Core → Other Applications

    
  
Product: Other Applications → Other Applications Graveyard

          You need to log in
          before you can comment on or make changes to this bug.