Closed
Bug 121925
Opened 24 years ago
Closed 24 years ago
nsDependentCString assertions
Categories
(Other Applications Graveyard :: Venkman JS Debugger, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.0
People
(Reporter: rginda, Assigned: rginda)
Details
Attachments
(1 file, 1 obsolete file)
|
3.38 KB,
patch
|
Details | Diff | Splinter Review |
Some (all?) of the |string|s in jsdIDebuggerService.idl should probably be
migrated to const AStrings to save copying and convoluted code.
|
Assignee | |
Updated•24 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
|
|
Assignee | |
Comment 1•24 years ago
|
||
I think the problem I was worried about here was the slew of
###!!! ASSERTION: nsDependentCString must wrap a non-NULL buffer: 'aPtr', file
../../dist/include/string/nsDependentString.h, line 128
assertions the debugger caused. Patch coming up that avoids these assertions by
not attempting to wrap a null string.
|
|
Assignee | |
Comment 2•24 years ago
|
||
|
|
Assignee | |
Comment 3•24 years ago
|
||
small patch looking for review for 1.0.
|
|
Assignee | |
Comment 4•24 years ago
|
||
last patch is for another bug, please ignore.
Attachment #70703 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•24 years ago
|
Summary: string usage in debugger service idl → nsDependentCString assertions
|
||
Comment 5•24 years ago
|
||
Looks okay to me, but feel free to use PL_strdup instead of
ToNewCString(nsDependentCString(...)). If you already know the length of the
string, you'll want to use PL_strndup instead.
|
|
Assignee | |
Comment 6•24 years ago
|
||
fix went is with bug 109652
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
|
||
Updated•21 years ago
|
Product: Core → Other Applications
|
||
Updated•7 years ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•