1219300 - Intermittent object-fit-contain-webm-001.html | application crashed [@ mozilla::Maybe<bool>::emplace<bool>(bool &&)][unknown top frame] after Assertion failure: !mIsSome, at Maybe.h:385

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://treeherder.mozilla.org/logviewer.html#?job_id=16388093&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=3184474&repo=b2g-inbound

Comment 1

[Intermittent Failures Robot]

41 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-central: 15
* mozilla-aurora: 10
* b2g-inbound: 7
* mozilla-inbound: 5
* fx-team: 4

Platform breakdown:
* windows7-32: 41

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1219300&startday=2015-10-29&endday=2015-10-29&tree=all

Comment 2

[Intermittent Failures Robot]

26 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 10
* mozilla-aurora: 6
* fx-team: 6
* mozilla-central: 2
* b2g-inbound: 2

Platform breakdown:
* windows7-32: 26

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1219300&startday=2015-10-30&endday=2015-10-30&tree=all

Comment 3

[Intermittent Failures Robot]

29 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 18
* mozilla-central: 7
* fx-team: 4

Platform breakdown:
* windows7-32: 29

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1219300&startday=2015-10-31&endday=2015-10-31&tree=all

Comment 4

[Intermittent Failures Robot]

142 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 52
* mozilla-central: 27
* mozilla-aurora: 25
* fx-team: 22
* b2g-inbound: 16

Platform breakdown:
* windows7-32: 142

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1219300&startday=2015-10-26&endday=2015-11-01&tree=all

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=3211888

 18:30:00     INFO -  REFTEST TEST-START | file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-contain-webm-001.html
 108351 
 18:30:00     INFO -  REFTEST TEST-LOAD | file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/webm-video/object-fit-contain-webm-001.html | 8523 / 12874 (66%)
 108352 
 18:30:00     INFO -  ++DOMWINDOW == 66 (0C30BC00) [pid = 3556] [serial = 25179] [outer = 13B7B780]
 108353 
 18:30:01     INFO -  [3556] WARNING: NS_ENSURE_TRUE(SUCCEEDED(hr)) failed: file c:/builds/moz2_slave/b2g-in-w32-d-00000000000000000/build/src/dom/media/platforms/wmf/MFTDecoder.cpp, line 39
 108354 
 18:30:01     INFO -  [3556] WARNING: NS_ENSURE_TRUE(SUCCEEDED(hr)) failed: file c:/builds/moz2_slave/b2g-in-w32-d-00000000000000000/build/src/dom/media/platforms/wmf/MFTDecoder.cpp, line 39
 108355 
 18:30:01     INFO -  Assertion failure: !mIsSome, at c:\builds\moz2_slave\b2g-in-w32-d-00000000000000000\build\src\obj-firefox\dist\include\mozilla/Maybe.h:385
 108356 
 18:30:01     INFO -  #01: mozilla::CanCreateWMFDecoder<CLSID_WebmMfVp9Dec> [dom/media/platforms/wmf/WMFDecoderModule.cpp:160]
 108357 
 18:30:01     INFO -  #02: mozilla::WMFDecoderModule::SupportsMimeType(nsACString_internal const &) [dom/media/platforms/wmf/WMFDecoderModule.cpp:186]
 108358 
 18:30:01     INFO -  #03: mozilla::PDMFactory::CreateDecoder(mozilla::TrackInfo const &,mozilla::FlushableTaskQueue *,mozilla::MediaDataDecoderCallback *,mozilla::layers::LayersBackend,mozilla::layers::ImageContainer *) [dom/media/platforms/PDMFactory.cpp:149]
 108359 
 18:30:01     INFO -  #04: mozilla::MediaFormatReader::EnsureDecodersCreated() [dom/media/MediaFormatReader.cpp:395]
 108360 
 18:30:01     INFO -  #05: mozilla::MediaFormatReader::HandleDemuxedSamples(mozilla::TrackInfo::TrackType,mozilla::AbstractMediaDecoder::AutoNotifyDecoded &) [dom/media/MediaFormatReader.cpp:836]
 108361 
 18:30:01     INFO -  #06: mozilla::MediaFormatReader::Update(mozilla::TrackInfo::TrackType) [dom/media/MediaFormatReader.cpp:1084]
 108362 
 18:30:01     INFO -  #07: nsRunnableMethodImpl<void ( mozilla::MediaFormatReader::*)(mozilla::TrackInfo::TrackType),1,mozilla::TrackInfo::TrackType>::Run() [xpcom/glue/nsThreadUtils.h:872]
 108363 
 18:30:01     INFO -  #08: mozilla::AutoTaskDispatcher::TaskGroupRunnable::Run() [xpcom/threads/TaskDispatcher.h:183]
 108364 
 18:30:01     INFO -  #09: mozilla::TaskQueue::Runner::Run() [xpcom/threads/TaskQueue.cpp:171]
 108365 
 18:30:01     INFO -  #10: nsThreadPool::Run() [xpcom/threads/nsThreadPool.cpp:222]
 108366 
 18:30:01     INFO -  #11: nsThread::ProcessNextEvent(bool,bool *) [xpcom/threads/nsThread.cpp:964]
 108367 
 18:30:01     INFO -  #12: NS_ProcessNextEvent(nsIThread *,bool) [xpcom/glue/nsThreadUtils.cpp:297]
 108368 
 18:30:01     INFO -  #13: mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate *) [ipc/glue/MessagePump.cpp:355]
 108369 
 18:30:01     INFO -  #14: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:234]
 108370 
 18:30:01     INFO -  #15: MessageLoop::RunHandler() [ipc/chromium/src/base/message_loop.cc:228]
 108371 
 18:30:01     INFO -  #16: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:202]
 108372 
 18:30:01     INFO -  #17: nsThread::ThreadFunc(void *) [xpcom/threads/nsThread.cpp:378]
 108373 
 18:30:01     INFO -  #18: _PR_NativeRunThread [nsprpub/pr/src/threads/combined/pruthr.c:397]
 108374 
 18:30:01     INFO -  #19: pr_root [nsprpub/pr/src/md/windows/w95thred.c:90]
 108375 
 18:30:01     INFO -  #20: MSVCR120 + 0x2c01d
 108376 
 18:30:01     INFO -  #21: MSVCR120 + 0x2c001
 108377 
 18:30:01     INFO -  #22: kernel32 + 0x53c45
 108378 
 18:30:01     INFO -  #23: ntdll + 0x637f5
 108379 
 18:30:01     INFO -  #24: ntdll + 0x637c8


Hi Benjamin,
Can you check this issue?

Comment 6

[Benjamin Chen [:bechen]]

I'll try to reproduce it first.

Comment 7

[Intermittent Failures Robot]

37 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 16
* mozilla-aurora: 7
* fx-team: 6
* mozilla-central: 4
* b2g-inbound: 4

Platform breakdown:
* windows7-32: 37

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1219300&startday=2015-11-02&endday=2015-11-02&tree=all

Comment 8

[Benjamin Chen [:bechen]]

After discussed with jwwang, we think the |result| variable need a lock to prevent racing. It is possible that multiple MediaElement(multiple MediaFormatReader) access the variable at the same time.

Comment 9

[Intermittent Failures Robot]

39 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 15
* mozilla-central: 9
* fx-team: 5
* b2g-inbound: 5
* mozilla-aurora: 4
* try: 1

Platform breakdown:
* windows7-32: 39

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1219300&startday=2015-11-03&endday=2015-11-03&tree=all

Comment 10

[Intermittent Failures Robot]

27 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 9
* fx-team: 8
* b2g-inbound: 6
* mozilla-central: 2
* mozilla-aurora: 2

Platform breakdown:
* windows7-32: 27

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1219300&startday=2015-11-04&endday=2015-11-04&tree=all

Comment 11

[Benjamin Chen [:bechen]]

Attachment: bug-1219300-wmflock.v01.patch

Comment 12

[Jean-Yves Avenard [:jya]]

Comment on attachment 8683492 [details] [diff] [review]
bug-1219300-wmflock.v01.patch

LGTM. But 403 to :cpearce

Comment 13

[Benjamin Chen [:bechen]]

try server:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bbf3661d7217

Comment 14

[Intermittent Failures Robot]

25 automation job failures were associated with this bug yesterday.

Repository breakdown:
* fx-team: 8
* b2g-inbound: 7
* mozilla-inbound: 5
* mozilla-central: 2
* mozilla-aurora: 2
* try: 1

Platform breakdown:
* windows7-32: 25

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1219300&startday=2015-11-05&endday=2015-11-05&tree=all

Comment 15

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8683492 [details] [diff] [review]
bug-1219300-wmflock.v01.patch

Review of attachment 8683492 [details] [diff] [review]:
-----------------------------------------------------------------

Please include commit messages in patches that summarize what they're doing and why.

Comment 16

[Benjamin Chen [:bechen]]

Attachment: bug-1219300-wmflock.v01.patch

Add commit message.
r=cpearce

Comment 17

[Intermittent Failures Robot]

41 automation job failures were associated with this bug yesterday.

Repository breakdown:
* try: 13
* mozilla-inbound: 11
* mozilla-central: 8
* b2g-inbound: 6
* fx-team: 2
* mozilla-aurora: 1

Platform breakdown:
* windows7-32: 40
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1219300&startday=2015-11-06&endday=2015-11-06&tree=all

Comment 18

[Intermittent Failures Robot]

192 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 65
* fx-team: 33
* b2g-inbound: 32
* mozilla-central: 28
* try: 18
* mozilla-aurora: 16

Platform breakdown:
* windows7-32: 191
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1219300&startday=2015-11-02&endday=2015-11-08&tree=all

Comment 19

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/39c48954dd49

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/39c48954dd49

Comment 21

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This is still happening somewhat frequently on aurora. Should we uplift this?

Comment 22

[Intermittent Failures Robot]

18 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-aurora: 12
* mozilla-inbound: 4
* try: 1
* mozilla-central: 1

Platform breakdown:
* windows7-32: 18

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1219300&startday=2015-11-09&endday=2015-11-15&tree=all

Comment 23

[Benjamin Chen [:bechen]]

(In reply to Wes Kocher (:KWierso) from comment #21)
> This is still happening somewhat frequently on aurora. Should we uplift this?

Yes, please.

Comment 24

[Intermittent Failures Robot]

9 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-aurora: 9

Platform breakdown:
* windows7-32: 9

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1219300&startday=2015-11-16&endday=2015-11-22&tree=all

Comment 25

[Benjamin Chen [:bechen]]

Comment on attachment 8684079 [details] [diff] [review]
bug-1219300-wmflock.v01.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1211339
[User impact if declined]: reftest failure
[Describe test coverage new/current, TreeHerder]: webm-video/object-fit-contain-webm-001.html
[Risks and why]: low
[String/UUID change made/needed]: none

Comment 26

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8684079 [details] [diff] [review]
bug-1219300-wmflock.v01.patch

Taking it as it's fixing an intermittent test failure. Aurora44+

Comment 27

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d3d3c9f2ea37