Closed Bug 1219308 Opened 5 years ago Closed 5 years ago

Change BrowserSearch from a const to a var because ES7 changed how 'const' works

Categories

(SeaMonkey :: Search, defect)

defect
Not set
normal

Tracking

(seamonkey2.42 fixed)

RESOLVED FIXED
seamonkey2.42
Tracking Status
seamonkey2.42 --- fixed

People

(Reporter: philip.chee, Assigned: philip.chee)

Details

Attachments

(1 file)

Change |const BrowserSearch| to |var BrowserSearch| to avoid problems due to wonky global lexical scope in ES7
Attachment #8680099 - Flags: review?(iann_bugzilla)
Summary: Changeset: Change BrowserSearch from a const to a var because ES7 changed how 'const' works → Change BrowserSearch from a const to a var because ES7 changed how 'const' works
Comment on attachment 8680099 [details] [diff] [review]
Patch v1.0 Proposed fix

Will there be others in our code?
Attachment #8680099 - Flags: review?(iann_bugzilla) → review+
> Will there be others in our code?
Only _THE SHADOW_ knows what evil lurks in the heart of our code.
Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/83a9ccd2a3fd
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.42
You need to log in before you can comment on or make changes to this bug.