Closed
Bug 1219308
Opened 9 years ago
Closed 9 years ago
Change BrowserSearch from a const to a var because ES7 changed how 'const' works
Categories
(SeaMonkey :: Search, defect)
SeaMonkey
Search
Tracking
(seamonkey2.42 fixed)
RESOLVED
FIXED
seamonkey2.42
| Tracking | Status | |
|---|---|---|
| seamonkey2.42 | --- | fixed |
People
(Reporter: philip.chee, Assigned: philip.chee)
Details
Attachments
(1 file)
|
969 bytes,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
Change |const BrowserSearch| to |var BrowserSearch| to avoid problems due to wonky global lexical scope in ES7
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8680099 -
Flags: review?(iann_bugzilla)
|
|
Assignee | |
Updated•9 years ago
|
Summary: Changeset: Change BrowserSearch from a const to a var because ES7 changed how 'const' works → Change BrowserSearch from a const to a var because ES7 changed how 'const' works
Comment on attachment 8680099 [details] [diff] [review]
Patch v1.0 Proposed fix
Will there be others in our code?
Attachment #8680099 -
Flags: review?(iann_bugzilla) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
> Will there be others in our code?
Only _THE SHADOW_ knows what evil lurks in the heart of our code.
|
|
Assignee | |
Comment 4•9 years ago
|
||
Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/83a9ccd2a3fd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
affected → ---
status-seamonkey2.42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.42
You need to log in
before you can comment on or make changes to this bug.
Description
•