1219332 - Enable some tests now that we're running on Jenkins with 512MB

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

I noticed these tests disabled because of problems in usage with 319MB:
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/cards_view/manifest.ini#8
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/cards_view/manifest.ini#13
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/rocketbar/manifest.ini#11

We should enable them (after checking if they don't cause failures).

Comment 1

[Martijn Wargers (dead)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/32844

Sorry, this is a combination of this bug and bug 1219378 and bug 1219619. Sometimes it's just easier to do it all at once, since they're all connected more or less.
InvisibleHtmlBinaryControl is not used anymore after this pull request, so I could remove it.

HtmlBinaryControl is only used by phone call log after this pull request.

At some point, we could make the Network & Connectivity settings page make its own PageRegion, so we don't need to put that stuff in the Settings app.

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8680570 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/32844

Good cleanup. I think there's an extra small removal we could do. I won't block on it, though

Comment 3

[Martijn Wargers (dead)]

Comment on attachment 8680570 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/32844

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #2)
> Good cleanup. I think there's an extra small removal we could do. I won't
> block on it, though

Yeah, that part could probably be removed or improved in some way. I'll wait on what No-Jun says about it.

Comment 4

[No-Jun Park [:njpark]]

Comment on attachment 8680570 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/32844

I think the code looks good.  I think we can still leave the asserts that checks the icon presence, since it doesn't really add much overhead and it can detect rare bugs which fails to display the icons (and the user do rely on icons in such instances)

Comment 5

[Martijn Wargers (dead)]

Ok, I left the asserts in.

Merged: https://github.com/mozilla-b2g/gaia/commit/8e3f62961e13567f0672a3647b332e1ea745f954