1219333 - Make homescreens a separate document type, at least in elasticsearch

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect, P3)

Description

[Mathieu Pillard [:mat]]

We implemented homescreens in bug 1214745 and bug 1214784 as a regular Webapp with a new method is_homescreen(), and index those as webapps in elasticsearch.

We then added a is_homescreen GET parameter that enables/disable homescreens, but this doesn't cover all existing cases because we need to:
- Search only through homescreens
- Search through all webapps, including homescreens
- Search through webapps excluding homescreens (for devices incompatible with homescreens)

The right way to do this is a separate index/document type, and then just pick the right doc_type parameter to send from the client (doc_type can accept multiple types). That does not have to mean a separate model in the db, through, we just need to choose the right indexer class when indexing.

Note that this bug has 2 components: the API and then the frontend, which will need to be updated once the API treats homescreens as a separate doc type.

Comment 1

[Allen Short [:ashort]]

https://github.com/mozilla/zamboni/commit/a7a2aa8d0f061e3c1eea5137fddd5930917a837c