Add a UI Telemetry probe for the 'Add to Reading List' web context menu

RESOLVED FIXED in Firefox 43, Firefox OS v2.5

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

unspecified
Firefox 45
Points:
---

Firefox Tracking Flags

(firefox43 fixed, firefox44 fixed, firefox45 fixed, b2g-v2.5 fixed)

Details

Attachments

(1 attachment)

We have telemetry probes for all the other web context menus.
Created attachment 8680274 [details] [diff] [review]
webcontextmenu-readinglist v0.1

This patch adds two probes:
1. action.1 because this is a contextmenu usage. We use the "web_" prefix which is convention.
2. save.1 because we are adding to the reading list. If the link is already in the reading list, we just fail silently, so we don't need the unsave.1 here to handle "toggle effects".
Assignee: nobody → mark.finkle
Attachment #8680274 - Flags: review?(margaret.leibovic)

Comment 2

3 years ago
Comment on attachment 8680274 [details] [diff] [review]
webcontextmenu-readinglist v0.1

Review of attachment 8680274 [details] [diff] [review]:
-----------------------------------------------------------------

Might be worth a mailing list post to remind reviewers to think about whether things need telemetry probes before granting r+.
Attachment #8680274 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/mozilla-central/rev/8de1dc055999
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45

Comment 5

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/8de1dc055999
status-b2g-v2.5: --- → fixed
Comment on attachment 8680274 [details] [diff] [review]
webcontextmenu-readinglist v0.1

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Gives us more complete telemetry
[Describe test coverage new/current, TreeHerder]: Working fine on Nightly
[Risks and why]: Low. Just adds a simple probe.
[String/UUID change made/needed]: None
Attachment #8680274 - Flags: approval-mozilla-beta?
Attachment #8680274 - Flags: approval-mozilla-aurora?
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5: fixed → ---
status-firefox43: --- → affected
status-firefox44: --- → affected
Comment on attachment 8680274 [details] [diff] [review]
webcontextmenu-readinglist v0.1

Should be in 43 beta 2.
Attachment #8680274 - Flags: approval-mozilla-beta?
Attachment #8680274 - Flags: approval-mozilla-beta+
Attachment #8680274 - Flags: approval-mozilla-aurora?
Attachment #8680274 - Flags: approval-mozilla-aurora+

Comment 9

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/3ec252297a49
status-firefox44: affected → fixed

Comment 10

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/e728e4f632e5
status-firefox43: affected → fixed
You need to log in before you can comment on or make changes to this bug.