Closed Bug 1219447 Opened 5 years ago Closed 5 years ago

Add a UI Telemetry probe for the 'Add to Reading List' web context menu

Categories

(Firefox for Android :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 45
Tracking Status
firefox43 --- fixed
firefox44 --- fixed
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

We have telemetry probes for all the other web context menus.
This patch adds two probes:
1. action.1 because this is a contextmenu usage. We use the "web_" prefix which is convention.
2. save.1 because we are adding to the reading list. If the link is already in the reading list, we just fail silently, so we don't need the unsave.1 here to handle "toggle effects".
Assignee: nobody → mark.finkle
Attachment #8680274 - Flags: review?(margaret.leibovic)
Comment on attachment 8680274 [details] [diff] [review]
webcontextmenu-readinglist v0.1

Review of attachment 8680274 [details] [diff] [review]:
-----------------------------------------------------------------

Might be worth a mailing list post to remind reviewers to think about whether things need telemetry probes before granting r+.
Attachment #8680274 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/mozilla-central/rev/8de1dc055999
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Comment on attachment 8680274 [details] [diff] [review]
webcontextmenu-readinglist v0.1

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Gives us more complete telemetry
[Describe test coverage new/current, TreeHerder]: Working fine on Nightly
[Risks and why]: Low. Just adds a simple probe.
[String/UUID change made/needed]: None
Attachment #8680274 - Flags: approval-mozilla-beta?
Attachment #8680274 - Flags: approval-mozilla-aurora?
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
Comment on attachment 8680274 [details] [diff] [review]
webcontextmenu-readinglist v0.1

Should be in 43 beta 2.
Attachment #8680274 - Flags: approval-mozilla-beta?
Attachment #8680274 - Flags: approval-mozilla-beta+
Attachment #8680274 - Flags: approval-mozilla-aurora?
Attachment #8680274 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.