1219447 - Add a UI Telemetry probe for the 'Add to Reading List' web context menu

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

We have telemetry probes for all the other web context menus.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: webcontextmenu-readinglist v0.1

This patch adds two probes:
1. action.1 because this is a contextmenu usage. We use the "web_" prefix which is convention.
2. save.1 because we are adding to the reading list. If the link is already in the reading list, we just fail silently, so we don't need the unsave.1 here to handle "toggle effects".

Comment 2

[:Margaret Leibovic]

Comment on attachment 8680274 [details] [diff] [review]
webcontextmenu-readinglist v0.1

Review of attachment 8680274 [details] [diff] [review]:
-----------------------------------------------------------------

Might be worth a mailing list post to remind reviewers to think about whether things need telemetry probes before granting r+.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8de1dc055999

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8de1dc055999

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/8de1dc055999

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8680274 [details] [diff] [review]
webcontextmenu-readinglist v0.1

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Gives us more complete telemetry
[Describe test coverage new/current, TreeHerder]: Working fine on Nightly
[Risks and why]: Low. Just adds a simple probe.
[String/UUID change made/needed]: None

Comment 7

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8680274 [details] [diff] [review]
webcontextmenu-readinglist v0.1

Should be in 43 beta 2.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3ec252297a49

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e728e4f632e5

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/3ec252297a49