1219498 - Move all GC setup down to be per GC cycle

Status: NEW

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: 58_move_all_gc_state_into_cycle-v0.diff

This is the other half of bug 1202923.

Comment 1

[Jon Coppeard (:jonco)]

Comment on attachment 8680334 [details] [diff] [review]
58_move_all_gc_state_into_cycle-v0.diff

Review of attachment 8680334 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsgc.cpp
@@ +6194,5 @@
>  GCRuntime::gcCycle(bool nonincrementalByAPI, SliceBudget& budget, JS::gcreason::Reason reason)
>  {
> +    AutoTraceLog logGC(TraceLoggerForMainThread(rt), TraceLogger_GC);
> +    AutoStopVerifyingBarriers av(rt, IsShutdownGC(reason));
> +    AutoEnqueuePendingParseTasksAfterGC aept(*this);

Is it OK to enqueue pending tasks if we're just about to re-enter the GC?

Comment 2

[Terrence Cole [:terrence]]

You are quite right. Thanks for catching that!

Try seems green, or at least green enough: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ac4120d1100

Comment 3

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7cb9a24f1ecd435b9925ce26927715607828a4c
Bug 1219498 - Move all GC state setup to be per-cycle; r=jonco

Comment 4

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00ceb22b0126ba3b23ff02b2479a0b17c917019f
Backout f7cb9a24f1ec (Bug 1219498) for its sinister associations with the GC on a CLOSED TREE.