Open
Bug 1219498
Opened 9 years ago
Updated 1 year ago
Move all GC setup down to be per GC cycle
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
NEW
Tracking | Status | |
---|---|---|
firefox44 | --- | affected |
People
(Reporter: terrence, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
2.43 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
This is the other half of bug 1202923.
Attachment #8680334 -
Flags: review?(jcoppeard)
Comment 1•9 years ago
|
||
Comment on attachment 8680334 [details] [diff] [review] 58_move_all_gc_state_into_cycle-v0.diff Review of attachment 8680334 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jsgc.cpp @@ +6194,5 @@ > GCRuntime::gcCycle(bool nonincrementalByAPI, SliceBudget& budget, JS::gcreason::Reason reason) > { > + AutoTraceLog logGC(TraceLoggerForMainThread(rt), TraceLogger_GC); > + AutoStopVerifyingBarriers av(rt, IsShutdownGC(reason)); > + AutoEnqueuePendingParseTasksAfterGC aept(*this); Is it OK to enqueue pending tasks if we're just about to re-enter the GC?
Attachment #8680334 -
Flags: review?(jcoppeard) → review+
Reporter | ||
Comment 2•9 years ago
|
||
You are quite right. Thanks for catching that! Try seems green, or at least green enough: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ac4120d1100
Reporter | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7cb9a24f1ecd435b9925ce26927715607828a4c Bug 1219498 - Move all GC state setup to be per-cycle; r=jonco
Reporter | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/00ceb22b0126ba3b23ff02b2479a0b17c917019f Backout f7cb9a24f1ec (Bug 1219498) for its sinister associations with the GC on a CLOSED TREE.
Updated•3 years ago
|
Assignee: terrence.d.cole → nobody
Status: ASSIGNED → NEW
Updated•1 year ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•