1219521 - GENERATED_FILES should automatically add imported python modules in the tree as dependencies

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

Bug 1215526 added the ability for a generating script to return a set of dependencies, we can further determine that imported modules in the tree are dependencies automatically instead of listing them manually.

Comment 1

[(not currently active) Ted Mielczarek]

Related: bug 1058662

Comment 2

[Chris Manchester (limited bugmail, email directly)]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #1)
> Related: bug 1058662

I'm thinking that feature should cover itself cover imported files, so I'm looking into finishing that off.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1219521 - Add imported python modules in the tree to dependencies of GENERATED_FILES scripts. r=glandium

Bug 1219521 - Add imported python modules in the tree to dependencies of GENERATED_FILES scripts. r=glandium

Comment 4

[Chris Manchester (limited bugmail, email directly)]

(In reply to Chris Manchester [:chmanchester] from comment #2)
> (In reply to Ted Mielczarek [:ted.mielczarek] from comment #1)
> > Related: bug 1058662
> 
> I'm thinking that feature should cover itself cover imported files, so I'm
> looking into finishing that off.

Comment 3 is a simpler solution based on glandium's feedback.

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8687453 [details]
MozReview Request: Bug 1219521 - Add imported python modules in the tree to dependencies of GENERATED_FILES scripts. r=glandium

https://reviewboard.mozilla.org/r/25211/#review22811

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/52f1f033d190

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/52f1f033d190