Closed Bug 1219521 Opened 4 years ago Closed 4 years ago

GENERATED_FILES should automatically add imported python modules in the tree as dependencies

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

Details

Attachments

(1 file)

Bug 1215526 added the ability for a generating script to return a set of dependencies, we can further determine that imported modules in the tree are dependencies automatically instead of listing them manually.
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #1)
> Related: bug 1058662

I'm thinking that feature should cover itself cover imported files, so I'm looking into finishing that off.
Bug 1219521 - Add imported python modules in the tree to dependencies of GENERATED_FILES scripts. r=glandium
Attachment #8687453 - Flags: review?(mh+mozilla)
(In reply to Chris Manchester [:chmanchester] from comment #2)
> (In reply to Ted Mielczarek [:ted.mielczarek] from comment #1)
> > Related: bug 1058662
> 
> I'm thinking that feature should cover itself cover imported files, so I'm
> looking into finishing that off.

Comment 3 is a simpler solution based on glandium's feedback.
Comment on attachment 8687453 [details]
MozReview Request: Bug 1219521 - Add imported python modules in the tree to dependencies of GENERATED_FILES scripts. r=glandium

https://reviewboard.mozilla.org/r/25211/#review22811
Attachment #8687453 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/52f1f033d190
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Assignee: nobody → cmanchester
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.