Closed Bug 1219566 Opened 5 years ago Closed 5 years ago

Add aarch64 macro to webrtc/trunk/build/build_config.h

Categories

(Core :: WebRTC, defect, P3)

Unspecified
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed
b2g-v2.5 --- fixed
Blocking Flags:

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

Nothing define for aarch64.  It is referenced by ipc/glue.


 0:06.44 Unified_cpp_ipc_glue1.o
 0:06.55 In file included from /mozilla/mozilla-central/ipc/chromium/src/base/port.h:9:0,
 0:06.55                  from /mozilla/mozilla-central/ipc/chromium/src/base/basictypes.h:12,
 0:06.55                  from /mozilla/mozilla-central/ipc/chromium/src/base/process_util.h:11,
 0:06.55                  from ../../dist/include/ipc/IPCMessageUtils.h:10,
 0:06.55                  from /mozilla/mozilla-central/obj-aarch64-linux-gnu/ipc/ipdl/_ipdlheaders/mozilla/ipc/URIParams.h:12,
 0:06.55                  from /mozilla/mozilla-central/ipc/glue/URIUtils.h:8,
 0:06.55                  from /mozilla/mozilla-central/ipc/glue/URIUtils.cpp:5:
 0:06.55 /mozilla/mozilla-central/media/webrtc/trunk/build/build_config.h:160:2: error: #error Please add support for your architecture in build/build_config.h
 0:06.55  #error Please add support for your architecture in build/build_config.
Attached patch add aarch64Splinter Review
Comment on attachment 8680480 [details] [diff] [review]
add aarch64

Chromium uses ARCH_CPU_ARM64, so we use same macro for aarch64.
Attachment #8680480 - Flags: review?(rjesup)
Assignee: nobody → m_kato
Attachment #8680480 - Flags: review?(rjesup) → review+
backlog: --- → webrtc/webaudio+
Rank: 38
Priority: -- → P3
https://hg.mozilla.org/mozilla-central/rev/189d4b0f9f23
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.