Closed
Bug 1219584
Opened 9 years ago
Closed 9 years ago
Add a test that the no-allocation-stacks message does *not* show up if allocations stacks are present
Categories
(DevTools :: Memory, defect, P3)
DevTools
Memory
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
6.30 KB,
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
Follow up to bug 1219421
Assignee | ||
Updated•9 years ago
|
Has STR: --- → irrelevant
Assignee | ||
Updated•9 years ago
|
Blocks: memory-testing
Assignee | ||
Updated•9 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8710199 -
Flags: review?(jsantell)
Assignee | ||
Comment 2•9 years ago
|
||
Updated•9 years ago
|
Attachment #8710199 -
Flags: review?(jsantell) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Ok I think that try push is actually everything passing, but most suites don't have any tests tagged "devtools-memory" which I filtered for, and so are failing because no assertions passed or failed. I think using tags is a great idea in theory, but in practice our infra just sucks at it.
Here is a complete mochitests try push, to confirm that hypothesis: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ec81b40d8da
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 5•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment 6•9 years ago
|
||
[bugday-20160323]
Status: RESOLVED,FIXED -> UNVERIFIED
Comments:
STR: Not clear.
Developer specific testing
Component:
Name Firefox
Version 46.0b9
Build ID 20160322075646
Update Channel beta
User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS Windows 7 SP1 x86_64
Expected Results:
Developer specific testing
Actual Results:
As expected
Comment 7•9 years ago
|
||
[bugday-20160323]
Status: RESOLVED,FIXED -> UNVERIFIED
Comments:
STR: Not clear.
Developer specific testing
Component:
Name Firefox
Version 46.0b9
Build ID 20160322075646
Update Channel beta
User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS Windows 7 SP1 x86_64
Expected Results:
Developer specific testing
Actual Results:
As expected
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•