Closed Bug 1219608 Opened 6 years ago Closed 6 years ago

Don't display repeats:1 in the animation tooltips when the animation has just 1 iteration count

Categories

(DevTools :: Inspector: Animations, defect)

defect
Not set
normal

Tracking

(firefox46 fixed)

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed

People

(Reporter: pbro, Assigned: pbro, Mentored)

References

Details

(Whiteboard: [polish-backlog][difficulty=easy])

Attachments

(1 file, 1 obsolete file)

STR:
- open jsbin.com
- open the animation inspector
- click on the jsbin logo to trigger the animation
- wait for animations to be displayed in the tool
- hover over one of the animations in the tool

==> The tooltip contains the label: "repeats: 1"

If the animation repeats only once (which is the default, and probably the most used value), we shouldn't even display this information in the tooltip at all.
We should only display it if the animation repeats infinitely or >= 2.
Bug 1219608 - Don't display repeats:1 when the animation has 1 iteration count; r?pbrosset
Attachment #8690468 - Flags: review?(pbrosset)
Assignee: nobody → aaronraimist
Comment on attachment 8690468 [details]
MozReview Request: Bug 1219608 - Don't display repeats:1 when the animation has 1 iteration count; r?pbrosset

https://reviewboard.mozilla.org/r/25863/#review23285

This looks good. Thanks for fixing this.
Would you mind also fixing the following test: \devtools\client\animationinspector\test\browser_animation_timeline_shows_time_info.js ?
For now, it assumes that all animations displayed have a tooltip that contains the string "Repeats:".
Attachment #8690468 - Flags: review?(pbrosset)
Component: Developer Tools: Inspector → Developer Tools: Animation Inspector
I did the minor test update that was needed for this patch, and pushed to TRY:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f46b7c0f8cb
Assignee: aaronraimist → pbrosset
Attachment #8690468 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8700547 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/446a82134ef2
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments:
STR: 
Test successful.


Component: 
Name 			 Firefox
Version 		 46.0b9
Build ID 		 20160322075646
Update Channel 	         beta
User Agent 		 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS                       Windows 7 SP1 x86_64

Expected Results: 
No message when one iteration is performed.
And 2nd case, animation is not iterating >=2.

Actual Results: 
As expected
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.