1219632 - Implement *test_browser_navigation.py* as an integration test in JavaScript

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[William Hsu [:whsu]]

https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/browser/test_browser_navigation.py

Comment 1

[Alberto Pastor [:albertopq]]

This is already covered by

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/browser_chrome_back_forward_btn_test.js

Comment 2

[Johan Lorenzo [:jlorenzo]]

Thanks for pointing this test out. I'm not sure this test is at parity with the Python one, though. If I understand browser_chrome_back_forward_btn_test.js, we just verify the back button is here, but we don't use it. Do we have another test that taps on the back button, Alberto?

Regarding the forward one, I don't see where we check the presence of it. Could you point where we verify that? Also, I'm not familiar of the code, does the forward button share all its on-pressed code with the back button? If not, I'd recommend to add a test which taps on it. What do you think?

Comment 3

[Alberto Pastor [:albertopq]]

Hey Jayme! Thanks for checking this.
We have several places where we click on the back button ([1] for example), but is true that none of those is checking the content after clicking. I'll try to replicate the same use case that the Gip test in browser_chrome_back_forward_btn_test.js. Thanks!

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/browser_fullscreen_navigation_chrome_test.js#L75

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1219632-navigation-test > mozilla-b2g:master

Comment 5

[Alberto Pastor [:albertopq]]

Comment on attachment 8696289 [details] [review]
[gaia] albertopq:1219632-navigation-test > mozilla-b2g:master

Could you please take a look? Thanks!

Comment 6

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Comment on attachment 8696289 [details] [review]
[gaia] albertopq:1219632-navigation-test > mozilla-b2g:master

Alberto I think you meant to send this one to Johan based on the comments.  I'm not familiar enough with the ui-tests or js to review this.

Comment 7

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8696289 [details] [review]
[gaia] albertopq:1219632-navigation-test > mozilla-b2g:master

The test looks okay to me, based on the current style of the file.

One way to enhance the readability could be to have something like: 
>  test('navigation back and forward', function() {
>    var url = server.url('sample.html');
>    var browser = rocketbar.gotoBrowser(url);
>    assert.equal(browser.title, 'Sample page');
>
>    browser.navigateToFirstLinkAvailable();
>    assert.equal(browser.title, 'Dark page');
>
>    browser.goBack();
>    assert.equal(browser.title, 'Sample page');
>
>    browser.goForward();
>    assert.equal(browser.title, 'Dark page');
>  });

Every detail about waits and frame switches would be included in test/marionette/lib/*.js. For example:
> function goBack() {
>   this.client.switchToFrame();
>   this.appChromeBack.tap();
>   this.gotoBrowser();
> }

Comment 8

[Alberto Pastor [:albertopq]]

Ok, fixed the readability and pushed to master. Thanks for the review!

master: https://github.com/mozilla-b2g/gaia/commit/2428acaa800cee7f80a7aea895f83f976ab4b156