Closed
Bug 1219638
Opened 9 years ago
Closed 1 year ago
[e10s] Tab separator flashes when opening a new tab
Categories
(Firefox :: Theme, defect, P5)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: phlsa, Unassigned)
References
Details
(Whiteboard: [qx:spec])
Attachments
(1 file)
319.14 KB,
image/png
|
Details |
When opening a new tab, the tab separator briefly flashes and overlays the new tab button. It shouldn't do that. Tested on OS X and Windows 10.
Comment 1•9 years ago
|
||
Can you still reproduce this? I just tried, and I don't see it, on either beta or current nightly (tested on OS X and Windows 8.1)
Flags: needinfo?(philipp)
Reporter | ||
Comment 2•9 years ago
|
||
I was still able to reproduce it in todays Nightly on Windows 10 but it seems to be really dependent on how busy the machine is. Looks like there are a few frames when the overlapping happens, and when the machine is busy, those are the frames that freeze quite often.
Flags: needinfo?(philipp)
Updated•9 years ago
|
Priority: -- → P5
Comment 3•8 years ago
|
||
Rakhi, can you reproduce this on your windows 10 machine if you try a few times?
Flags: needinfo?(Rakhish1994)
Comment 5•8 years ago
|
||
So, I am able to reproduce the bug, but still not able to find out how to fix this tab separator overlap. I noticed few things while trying: 1. I was not able to inspect it because overlap appears for a second only. I try to increase transition time so that I can inspect but no! overlap still appears for a second. 2.The selector that depends on [visuallyselected] not being set here, which is causing the separator to get shown here. This is different in e10s vs non-e10s because that attribute doesn't get set immediately. By disabling e10s, tab separator overlap doesn't happened(probably because in e10s we switch tabs asynchronously). Any idea about how fix this?
Flags: needinfo?(dao+bmo)
Comment 6•8 years ago
|
||
Sounds like more fallout from bug 1009628.
Flags: needinfo?(dao+bmo) → needinfo?(mconley)
Summary: Tab separator flashes when opening a new tab → [e10s] Tab separator flashes when opening a new tab
Comment 7•8 years ago
|
||
I wonder if it makes sense to hide the tab separators before and after a tab that is animating? That'd maybe sidestep this a little. Can you think of any problems with that solution, shorlander?
Flags: needinfo?(mconley) → needinfo?(shorlander)
Comment 8•8 years ago
|
||
(In reply to Mike Conley (:mconley) - (Needinfo me!) from comment #7) > I wonder if it makes sense to hide the tab separators before and after a tab > that is animating? That'd maybe sidestep this a little. > > Can you think of any problems with that solution, shorlander? Then you can't see the tab at all, right? You'd only see the [+] button moving with no separator before it. It'd also be weird for e.g. closing tabs in the middle of other tabs - you'd see a continuous blurb of the text of 3 tabs with no separators between them for a bit. Am I misunderstanding what you're proposing, Mike? Orthogonally, it doesn't really make sense to me that the tab separator ever displays *on top of* the new tab button. That shouldn't even be 'physically' possible in terms of the margins/paddings involved. Feels like we're missing something.
Flags: needinfo?(mconley)
Comment 9•8 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #8) > Then you can't see the tab at all, right? You'd only see the [+] button > moving with no separator before it. It'd also be weird for e.g. closing tabs > in the middle of other tabs - you'd see a continuous blurb of the text of 3 > tabs with no separators between them for a bit. Am I misunderstanding what > you're proposing, Mike? Yeah, that's accurate - I think my idea was a little half-baked. > > Orthogonally, it doesn't really make sense to me that the tab separator ever > displays *on top of* the new tab button. That shouldn't even be 'physically' > possible in terms of the margins/paddings involved. Feels like we're missing > something. Do we know that the separator is actually appearing on top of the newtab button? The screenshot doesn't make it super clear - since (from what I remember) the new tab button has a transparent background (and just shows an outline when hovered), perhaps we're seeing a tab separator leaking through that transparency?
Flags: needinfo?(mconley)
Comment 10•8 years ago
|
||
(In reply to Mike Conley (:mconley) - (Needinfo me!) from comment #9) > Do we know that the separator is actually appearing on top of the newtab > button? The screenshot doesn't make it super clear - since (from what I > remember) the new tab button has a transparent background (and just shows an > outline when hovered), perhaps we're seeing a tab separator leaking through > that transparency? I made the new tab button background opaque and I still the separator appearing. So it appears to be on top of it.
Flags: needinfo?(shorlander)
Updated•8 years ago
|
tracking-e10s:
--- → -
Updated•8 years ago
|
Updated•2 years ago
|
Severity: normal → S3
Comment 11•1 year ago
|
||
Unable to reproduce
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•