Closed Bug 1219644 Opened 9 years ago Closed 9 years ago

Implement *test_sort_contacts.py* as an integration test in JavaScript

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.6+)

Status:
RESOLVED FIXED
Project Flags:
feature-b2g 2.6+

People

(Reporter: whsu, Assigned: arcturus)

References

Details

(Whiteboard: [gip-to-gij])

Attachments

(1 file)

[gaia] arcturus:bug-1219644 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
jlorenzo
: review+
Details | Review
Component: Gaia::UI Tests → Gaia::Contacts
feature-b2g: --- → 2.6+

  

  


Assignee: nobody → francisco
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 8699126 [details] [review]
[gaia] arcturus:bug-1219644 > mozilla-b2g:master

I spliced the original python test into two js one each for the kind of sorting orders.

  

  



        Attachment #8699126 -
        Flags: review?(jlorenzo)

    
    

    
  
Comment on attachment 8699126 [details] [review]
[gaia] arcturus:bug-1219644 > mozilla-b2g:master

Splitting the test into 2 is a great thing!

I don't r+ yet, because it's not a good practice to manipulate the UI within a setup() step, for integration testing. I proposed an alternative solution in the PR.

  

  



        Attachment #8699126 -
        Flags: review?(jlorenzo)

    
    

    
  
Will follow the comments on gh, thanks a lot!

  

  



    
    

    
  
Comment on attachment 8699126 [details] [review]
[gaia] arcturus:bug-1219644 > mozilla-b2g:master

Suggestions added, also rebased with master :)

  

  



        Attachment #8699126 -
        Flags: review?(jlorenzo)

    
    

    
  
Comment on attachment 8699126 [details] [review]
[gaia] arcturus:bug-1219644 > mozilla-b2g:master

Yay! No more UI manipulation to insert the data in setup() :) 

That looks good to me.

  

  



        Attachment #8699126 -
        Flags: review?(jlorenzo) → review+

    
    

    
  
Landed:

https://github.com/mozilla-b2g/gaia/commit/c4668c36925aaf02165be8eda4b36825bdc54431

  

  


Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: