1219682 - Implement *test_lockscreen_wake_with_notification.py* as an integration test in JavaScript

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[William Hsu [:whsu]]

https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/lockscreen/test_lockscreen_wake_with_notification.py

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Greg, could you fold this into your current working item? Is this already a duplicate? Thanks.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] snowmantw:bug1219682 > mozilla-b2g:master

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8698866 [details] [review]
[gaia] snowmantw:bug1219682 > mozilla-b2g:master

Test result is good on TaskCluster:

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=894206b2236cac55023a2e63b15f185428250252&selectedJob=3163013

Therefore I set it for review.

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/873cc517274fe3c188402318cb212fba9c55f5b6

Comment 5

[Johan Lorenzo [:jlorenzo]]

Thank you for this new test.

I realized the Python test turns off the screen, so we make sure a new notification actually power up the screen. After injecting this piece of code[1] locally, it seems Mulet doesn't support turning on and off the screen. Do you confirm, Greg?

FWIW, the helper in MJS[2] only exposes screen lock/unlock.

[1] https://github.com/mozilla-b2g/gaia/blob/6e5e0cb1a95de119e93ad897f13b57eca039ce4e/tests/python/gaia-ui-tests/gaiatest/gaia_test.py#L754
[2] https://github.com/mozilla-b2g/gaia/blob/01ffe82cf088ca8fda9fe6783dc5cad2c3dde01c/tests/jsmarionette/helper.js#L27

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

Well, I will update the patch with that assertion and set you as the reviewer.

Also, I think the problem is we may need a `device` object as Gip so that we can check and manipulate it without scattering `Service.query` everywhere, and it will also map Gip to Gij more easily. Meanwhile,

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

Tim and I listed how much tests we should implement to cover more tests than Gip. So the device helper like that might be helpful.

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] snowmantw:bug1219682-rev2 > mozilla-b2g:master

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

Reopen because I need to update the assertions.

Comment 10

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8701304 [details] [review]
[gaia] snowmantw:bug1219682-rev2 > mozilla-b2g:master

Test passed again:

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=c3d5ade46fe2ae439eb05487f807e772f6dafc9f

So I set the review.

Comment 11

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8701304 [details] [review]
[gaia] snowmantw:bug1219682-rev2 > mozilla-b2g:master

Even though the test passes, and the Service actually returns the correct value, I don't see the screen turning off on Mulet. Hence, this test might be interpreted as a false positive.

I ran the test on device, it worked there. 

I'd add a comment explaining why you don't see screen being turned off on Mulet. 

Then, r+ modulo the comment.

Comment 12

[BMO Automation]

Firefox OS is not being worked on