1219712 - Syntax error running tests

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Jacobo Aragunde Pérez]

User Agent: Mozilla/5.0 (Fedora; Linux x86_64) AppleWebKit/601.1 (KHTML, like Gecko) Version/8.0 Safari/601.1 Epiphany/3.16.3

Steps to reproduce:

Ran tests with gulp test.


Actual results:

The following syntax error happened:
An exception occurred.
Traceback (most recent call last):
  File "resource://extensions.modules.addon-sdk.commonjs.path./sdk/timers.js", line 40, in notify
    callback.apply(null, args);
  File "resource://extensions.modules.addon-sdk.commonjs.path./sdk/deprecated/unit-test.js", line 389, in done/</<
    timer.setTimeout(_ => onDone(this));
  File "resource://extensions.modules.addon-sdk.commonjs.path./sdk/deprecated/unit-test.js", line 563, in start/this.onDone
    options.onDone(self);
  File "resource://extensions.modules.addon-sdk.commonjs.path./sdk/deprecated/unit-test.js", line 532, in runNextTest
    return tests.getNext().then((test) => {
  File "resource://extensions.modules.addon-sdk.commonjs.path./sdk/deprecated/unit-test-finder.js", line 195, in findTests/</<.getNext
    getNext: () => resolve(getNextTest())
  File "resource://extensions.modules.addon-sdk.commonjs.path./sdk/deprecated/unit-test-finder.js", line 162, in findTests/</getNextTest
    suiteModule = cuddlefish.main(loader, suite);
  File "resource://addon-sdk/test/test-simple-storage.js", line 287, in 
    compare = compare || (a, b) => a === b;
SyntaxError: invalid arrow-function arguments (parentheses around the arrow-function may help)

Comment 1

[Jacobo Aragunde Pérez]

Attachment: Pull request

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I went ahead and merged this r=test-only since it looked pretty simple. I didn't test it (and I'm not really a reviewer for this code), so hopefully everything goes well.

https://github.com/mozilla/addon-sdk/commit/7104879c2884e4178818eae3a0b975346c53ea0a

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Is this all that needs to happen, Dave, or do we need to mirror this into mozilla-central's copy still?

Comment 4

[Dave Townsend [:mossop]]

(In reply to Wes Kocher (:KWierso) from comment #3)
> Is this all that needs to happen, Dave, or do we need to mirror this into
> mozilla-central's copy still?

We shouldn't be landing stuff on github anymore. I can fix it up tomorrow though.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/574fcf1b4582

Comment 6

[Dave Townsend [:mossop]]

Landed this in fx-team and backtracked master to the earlier state. This change will merge to github once it has merged to mozilla-central. I've also made the addon-sdk repo read-only for most users.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/574fcf1b4582