Change the the depth limit of the thread hangs stack to use the 99th percentile

RESOLVED FIXED in Firefox 43, Firefox OS v2.5

Status

()

P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Dexter, Assigned: Dexter)

Tracking

Trunk
mozilla45
Points:
1

Firefox Tracking Flags

(firefox43 fixed, firefox44 fixed, firefox45 fixed, b2g-v2.5 fixed)

Details

(Whiteboard: [measurement:client])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We should change the maximum length of the thread hangs stack to the value of the 99th percentile rather than the 95th percentile as the most interesting stacks tend to be longer.

We need to run an updated spark job [0] to find the 99th percentile and then change the constant in [1].

[0] - https://gist.github.com/Dexterp37/fc4a043fb442d4e4be90
[1] - https://dxr.mozilla.org/mozilla-central/rev/1e700005a0ddf2b17803213e1f3f8d78a7a618b8/xpcom/threads/BackgroundHangMonitor.cpp#36
(Assignee)

Updated

3 years ago
Points: --- → 1
Priority: -- → P2
Whiteboard: [measurement:client]
Let's set the limit to 30 (99.9%).
(Assignee)

Comment 2

3 years ago
Created attachment 8680654 [details] [diff] [review]
bug1219751.patch
Assignee: nobody → alessio.placitelli
Status: NEW → ASSIGNED
Attachment #8680654 - Flags: review?(gfritzsche)
Attachment #8680654 - Flags: review?(gfritzsche) → review+
Priority: P2 → P1
(Assignee)

Comment 4

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/134bb8fdb24418730e1ed5940fafc42cdfc5e972
Bug 1219751 - Change the the depth limit of the thread hangs stack to use the 99th percentile. r=gfritzsche

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/134bb8fdb244
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45

Comment 6

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/134bb8fdb244
status-b2g-v2.5: --- → fixed
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5: fixed → ---
Can we uplift this to Aurora 44 & Beta 43?

See https://bugzilla.mozilla.org/show_bug.cgi?id=1211411#c11
Status: RESOLVED → REOPENED
Flags: needinfo?(alessio.placitelli)
Resolution: FIXED → ---
Blocks: 1222894
(Assignee)

Comment 9

3 years ago
Comment on attachment 8680654 [details] [diff] [review]
bug1219751.patch

Approval Request Comment
[Feature/regressing bug #]: Tweaks the constant that controls the number of thread hang stacks sent.
[User impact if declined]: This isn't a user-facing feature. However, without this patches bug 1222894 could potentially cause sending a lot of oversized pings, wasting both storage and processing time server side, thus increasing costs.
[Describe test coverage new/current, TreeHerder]: This has been on m-c for 2 weeks without any reported issue.
[Risks and why]: Low risk, the changed constant controls how many stacks we are sending.
[String/UUID change made/needed]: None.

Please note that this is part of an uplift stack required for bug 1222894. This is the stack (the patches correctly apply in order to mozilla-beta): 1213780, 1211411, 1215540, 1219751.
Flags: needinfo?(alessio.placitelli)
Attachment #8680654 - Flags: approval-mozilla-beta?
(Assignee)

Comment 10

3 years ago
Comment on attachment 8680654 [details] [diff] [review]
bug1219751.patch

This also needs to be uplifted on Aurora: the rest of the stack is already there and it's just missing this one patch.
Attachment #8680654 - Flags: approval-mozilla-aurora?
Marking this as affected for 43 and 44 since we intend to uplift.
status-firefox43: --- → affected
Comment on attachment 8680654 [details] [diff] [review]
bug1219751.patch

Please uplift this patch to both aurora and beta.
Attachment #8680654 - Flags: approval-mozilla-beta?
Attachment #8680654 - Flags: approval-mozilla-beta+
Attachment #8680654 - Flags: approval-mozilla-aurora?
Attachment #8680654 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/8efe7a54bafe
https://hg.mozilla.org/releases/mozilla-beta/rev/6cabb1a43af6
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
(In reply to Vladan Djeric (:vladan) -- please needinfo! PTO Nov 16/19/20 from comment #13)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/8efe7a54bafe
> https://hg.mozilla.org/releases/mozilla-beta/rev/6cabb1a43af6

setting the flags for this checkin
status-firefox43: affected → fixed
status-firefox44: affected → fixed
You need to log in before you can comment on or make changes to this bug.