1219761 - Implement a destruction handshake in PCompositable similar to PTexture's to avoid races between messages and the protocol

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Comment 1

[Nicolas Silva [:nical]]

Attachment: Move the deallocation handshake in a helper class and make PTexture and PCompositable use it.

This should fix the potential races between messages using a PCompositable actor and the actor's destruction.

Comment 2

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8680649 [details] [diff] [review]
Move the deallocation handshake in a helper class and make PTexture and PCompositable use it.

Review of attachment 8680649 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Looks good.

::: gfx/layers/IPDLActor.h
@@ +96,5 @@
> +  ~ParentActor() { MOZ_ASSERT(mDestroyed); }
> +
> +  bool CanSend() const { return !mDestroyed; }
> +
> +  // Override this rather than ActorDestroy 

nits. Remove space at end of the line.

::: gfx/layers/client/CompositableClient.cpp
@@ +159,5 @@
>  
>  bool
>  CompositableClient::Connect(ImageContainer* aImageContainer)
>  {
> +  MOZ_ASSERT(!IsConnected());

Isn't it better just checking MOZ_ASSERT(!mCompositableChild)?

::: gfx/layers/client/TiledContentClient.h
@@ +647,5 @@
>  protected:
>    ~MultiTiledContentClient()
>    {
>      MOZ_COUNT_DTOR(MultiTiledContentClient);
>   

nits. Remove redundant space.

::: gfx/layers/ipc/PCompositable.ipdl
@@ +30,2 @@
>  };
>      

nits. Remove redundant spaces.

Comment 3

[Nicolas Silva [:nical]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/932318a4e150

Comment 4

[Nicolas Silva [:nical]]

https://hg.mozilla.org/mozilla-central/rev/932318a4e150