1219971 - Failure in test_cost_control_reset_wifi.py, because of launch directly after a kill

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

I occasionally see this failure with this test, also happening on Jenkins:
TEST-UNEXPECTED-ERROR | test_cost_control_reset_wifi.py TestCostControlReset.test_cost_control_reset_wifi | ScriptTimeoutException: ScriptTimeoutException: timed out


Traceback (most recent call last):
  File "/Users/mwargers/.virtualenvs/zapion_test2/lib/python2.7/site-packages/marionette_client-1.0.0-py2.7.egg/marionette/marionette_test.py", line 296, in run
    testMethod()
  File "/Users/mwargers/B2G/gaia_clean/tests/python/gaia-ui-tests/gaiatest/tests/functional/cost_control/test_cost_control_reset_wifi.py", line 36, in test_cost_control_reset_wifi
    search.launch()
  File "/Users/mwargers/B2G/gaia_clean/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 26, in launch
    self.app = self.apps.launch(self.name, self.manifest_url, self.entry_point, launch_timeout=launch_timeout)
  File "/Users/mwargers/B2G/gaia_clean/tests/python/gaia-ui-tests/gaiatest/gaia_test.py", line 96, in launch
    % (manifest_url, json.dumps(entry_point)), script_timeout=launch_timeout)
  File "/Users/mwargers/.virtualenvs/zapion_test2/lib/python2.7/site-packages/marionette_driver-1.0.0-py2.7.egg/marionette_driver/marionette.py", line 1685, in execute_async_script
    rv = self._send_message("executeAsyncScript", body, key="value")
  File "/Users/mwargers/.virtualenvs/zapion_test2/lib/python2.7/site-packages/marionette_driver-1.0.0-py2.7.egg/marionette_driver/decorators.py", line 36, in _
    return func(*args, **kwargs)
  File "/Users/mwargers/.virtualenvs/zapion_test2/lib/python2.7/site-packages/marionette_driver-1.0.0-py2.7.egg/marionette_driver/marionette.py", line 716, in _send_message
    self._handle_error(resp)
  File "/Users/mwargers/.virtualenvs/zapion_test2/lib/python2.7/site-packages/marionette_driver-1.0.0-py2.7.egg/marionette_driver/marionette.py", line 770, in _handle_error
    raise errors.lookup(error)(message, stacktrace=stacktrace)
TEST-INFO took 108750ms

SUMMARY
-------
passed: 0
failed: 1
todo: 0

I think we need to add a time.sleep(0.5) after every kill, because this issue happens with more tests when calling launch after a kill, for instance here:
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/test_settings_media_storage_change.py#40

http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/gaia_test.py#134

http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/cost_control/test_cost_control_reset_wifi.py#36

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1219971 > mozilla-b2g:master

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8680957 [details] [review]
[gaia] mwargers:1219971 > mozilla-b2g:master

This small patch looks fine.

Comment 3

[No-Jun Park [:njpark]]

Comment on attachment 8680957 [details] [review]
[gaia] mwargers:1219971 > mozilla-b2g:master

looks straightforward

Comment 4

[Martijn Wargers (dead)]

Merged: https://github.com/mozilla-b2g/gaia/commit/c5599f6a15537becb0c2a2d6a0716da3a33b126e