1219974 - Add DisconnectIfExists() to MediaEventListener

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

It would come in handy when it is not easy to know whether this listener is already connected or not.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1219974 - Add DisconnectIfExists() to MediaEventListener. r=kinetik.

Bug 1219974 - Add DisconnectIfExists() to MediaEventListener. r=kinetik.

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 8680939 [details]
MozReview Request: Bug 1219974 - Add DisconnectIfExists() to MediaEventListener. r=kinetik.

https://reviewboard.mozilla.org/r/23703/#review21211

Do you think there's value in keeping Disconnect() public, since all existing callers could call DisconnectIfExists() instead?

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review.

As we have https://hg.mozilla.org/mozilla-central/file/1e700005a0dd/xpcom/threads/MozPromise.h#l839.

There is still merit in keeping Disconnect() when you know the listener should have been connected. It enforce some invariants and helps catch bugs where we think it is connected but in fact not.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/11fef9ecdefb

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/11fef9ecdefb

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/11fef9ecdefb

Comment 7

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion