Update tooltool rustc to 1.4

RESOLVED FIXED in Firefox 45, Firefox OS v2.5

Status

RESOLVED FIXED
3 years ago
8 months ago

People

(Reporter: rillian, Assigned: rillian)

Tracking

Trunk
mozilla45
Dependency tree / graph

Firefox Tracking Flags

(firefox45 fixed, b2g-v2.5 fixed)

Details

Attachments

(1 attachment)

Now that rustc 1.4.0 is stable, we should bump the version available in tooltool for integration builds.
(Assignee)

Comment 1

3 years ago
Created attachment 8680955 [details] [diff] [review]
Bump macosx64 tooltool manifest for rustc 1.4.0.

Build on MacOS X 10.10.5 (XCode 7.0.1) from https://static.rust-lang.org/dist/rustc-1.4.0-src.tar.gz with

MACOSX_DEPLOYMENT_TARGET=10.7
./configure --disable-elf-tls
(Assignee)

Comment 2

3 years ago
Comment on attachment 8680955 [details] [diff] [review]
Bump macosx64 tooltool manifest for rustc 1.4.0.

Green on try. https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6f1c59e9498

16:42:05     INFO -  checking rustc version... 1.4.0-dev (v1.4.0)
16:42:05     INFO -  checking rustc compatibility with MacOS X... 10.6 is ok with this rustc
Attachment #8680955 - Flags: review?(mshal)
Do you think we'll ever be able to use the stock rust release binaries?
(Assignee)

Comment 4

3 years ago
So far the rust maintainers have been unsupportive.

Note we can use upstream release builds on Linux and Windows; it's just MacOS X 10.6 support that needs a custom build. And android where there are no upstream release binaries. I'm hoping I can automate the mac build with taskcluster, which will remove some of the pain.

Alex, can you update us on MacOS X 10.6 tls support plans? I recall you had a follow-up idea which would allow you to drop --disable-elf-tls.
Flags: needinfo?(acrichton)
Unfortunately I haven't had the chance to flesh out a design to drop --disable-elf-tls, although I'd believe that it's still possible to do so! (as detailed in https://github.com/rust-lang/rust/issues/26581).

One point of note, however, is that we do actually have release binaries for Android now! We've got some more work to do to make them easily available, but all the pieces are in place to produce them and ensure they keep working.

How urgent is getting 10.6 binary support upstream? Is it bad enough that we should look into doing so sooner rather than later?
Flags: needinfo?(acrichton)
(In reply to Ralph Giles (:rillian) from comment #4)
> Note we can use upstream release builds on Linux and Windows; it's just
> MacOS X 10.6 support that needs a custom build. And android where there are
> no upstream release binaries. I'm hoping I can automate the mac build with
> taskcluster, which will remove some of the pain.

If you can cross-compile it from Linux then it should be straightforward to do in Taskcluster right now. If you need to build on a Mac then that's not something you can do just yet.

(In reply to Alex Crichton [:acrichto] from comment #5)
> How urgent is getting 10.6 binary support upstream? Is it bad enough that we
> should look into doing so sooner rather than later?

It's not a dealbreaker--it's not like we use upstream binaries for our other toolchains. It just seems silly to have to do a custom build of a toolchain that we're building in-house. :)
(Assignee)

Comment 7

3 years ago
(In reply to Alex Crichton [:acrichto] from comment #5)

> One point of note, however, is that we do actually have release binaries for
> Android now!

How wonderful. They're not linked from https://www.rust-lang.org/downloads.html. I found https://static.rust-lang.org/dist/rust-std-nightly-arm-linux-androideabi.tar.gz (cross build of the rust standard library) but haven't figured out how to hook it up. Does cargo doesn't seem to know either.
Right yeah, that's what I meant by "we've got some more work to do to make them easily available" :)

The gist of it is that the `rust-std-*` tarball has a `rustlib` directory containing the target triple (in this case arm-linux-androideabi), and if you put that in the normal rustc rustlib directory then rustc should be able to find the libs and cross compile to Andorid.
(Assignee)

Comment 9

3 years ago
Aha. I opened bug 1220307 to follow up on the cross support questions.

Updated

3 years ago
Attachment #8680955 - Flags: review?(mshal) → review+
(Assignee)

Updated

3 years ago
Blocks: 1219047

Comment 11

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4b3c08886ba9
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.