1219999 - Menu action buttons do not automatically expand to fill the remaining space in one is hidden

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot

I forced the share plane to be hidden in an unrelated patch and the remaining items in the menu do not fill in the space for the missing share plane – see the attached screenshot.

GeckoMenu uses View.GONE to hide the views [1] so I think the issue is how GeckoMenu.mSecondaryActionItemBar, a GeckoMenu$DefaultActionItemBar lays out the items, where it manually sets the LinearLayout weight sum.

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/menu/GeckoMenu.java?rev=5b439b4654e0#607
[2]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/menu/GeckoMenu.java?rev=5b439b4654e0#745

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Diff to repro (w/ IJ autoformat :d)

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Diff to fix

This diff shows that my suspicions were correct.

It is not a robust solution, however.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Worth noting that I was unable to figure out how to disable share via the restricted profiles on my N9 (the code is at [1]), so maybe this is a non-issue.

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/BrowserApp.java?rev=35d014ddd2a4#3042

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Michael Comella (:mcomella) from comment #3)
> Worth noting that I was unable to figure out how to disable share via the
> restricted profiles on my N9 (the code is at [1]), so maybe this is a
> non-issue.

Share is currently only disabled in Guest profiles, I think.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Sebastian Kaspari (:sebastian) from comment #4)
> Share is currently only disabled in Guest profiles, I think.

In Guest mode, the row entirely clears because there is also no bookmarking or reading list – I don't think this is an issue for restricted profiles (though note that the lines in between each header row are still there so it creates a weird graphical glitch).

This bug could be used to postpone bug 1217174, however, so I'm going to leave it open.

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.