Closed Bug 122000 Opened 23 years ago Closed 16 years ago

Moz apps require restart to pick up highlight color changes in System Preferences

Categories

(Core :: Widget: Cocoa, defect)

Product:
Core
Component:
Widget: Cocoa
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1b1

People

(Reporter: masri, Assigned: mstange)

References

Details

Attachments

(1 file)

fix
1.89 KB, patch
roc
: review+
roc
: superreview+
Details | Diff | Splinter Review
Platform: PowerBook G3/300/192Mb/48Gb, MacOS X 10.1.2 Fizzilla Build: 2002012403 I'm testing this with Classic skin. Try the following: 1) Launch Mozilla. 2) Select text in Mozilla, such as the location bar. 3) Apple Menu: System Preferences: General. 4) Choose a different highlight color. 5) Click back into Mozilla, and if necessary, reselect the text you had selected previously. What happens: Mozilla uses the highlight color you had selected previously. What should happen: Mozilla should honor the color selected in the General Preference Panel. - Adam
this is a dup
Whiteboard: DUPEME
This looks like a widget-level problem - perhaps the wrong system color is being fetched for drawing the text selection background color
Assignee: hewitt → pinkerton
Component: Themes → XP Toolkit/Widgets
Whiteboard: DUPEME
i guess we cache it in css and then never re-check it.
Assignee: pinkerton → pierre
Pierre has a bug on responding to "appearance changed" events I think.
Target Milestone: --- → mozilla1.2
Bulk moving Moz1.2 bugs to future-P2. I will pull from this list when scheduling work post Mozilla1.0
Priority: -- → P2
Target Milestone: mozilla1.2 → Future
I think nsXPLookAndFeel caches system colors. We'd also need to clear the data in the rule tree for the relevant structs and trigger a repaint...
Assigning pierre's remaining Style System-related bugs to myself.
Assignee: pierre → dbaron
Priority: P2 → P3
*** Bug 345019 has been marked as a duplicate of this bug. ***
This would be a wonderful fix for Camino. It's bothered me several times...
Resummarizing to more accurately reflect the situation.
Summary: Fizzilla doesn't honor highlight color chosen in System Preferences: General → Moz apps require restart to pick up highlight color changes in System Preferences
Markus, does bug 448767 fix this, or is that only touching the Appearance?
Attached patch fix — — Splinter Review
That's only touching the Appearance, but this is just as easy.
Assignee: dbaron → mstange
Status: NEW → ASSIGNED
Attachment #339628 - Flags: review?(roc)
Component: XUL → Widget: Cocoa
Priority: P3 → --
QA Contact: pmac → cocoa
Hardware: Macintosh → All
Target Milestone: Future → ---
pushed: http://hg.mozilla.org/mozilla-central/rev/5fa7d5e88e79
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: