1220061 - [B2GDroid]Browser's UA can't be correctly identified by youtube.

Status: RESOLVED FIXED

(B2GDroid Graveyard :: General, defect)

Description

[Verson Xiong (Leave from Mozilla)]

Attachment: logcat_1746.txt

[1.Description]:
[B2GDroid]Browser's UA can't be correctly identified by youtube, so browser opened youtube's abbreviated page, user can't play video via browser.
Found time:17:46
See attachment:AriesKK.3gp & logcat_1746.txt

[2.Testing Steps]: 
Prerequisite:turn on wifi.
1. Launch browser.
2. Go to "www.youtube.com".
3. Observe the page and try to play a video.

[3.Expected Result]: 
3. Browser should load youtube's HTML5 page and user can play video via browser.

[4.Actual Result]: 
3. Browser loaded youtube's abbreviated page and user can't play video via browser.

[5.Reproduction build]: 
Gecko: 44.0a1
Android version: 
4.4.4(Build Number 23.0.A.2.93)

[7.TCID]: 
6073

[8.Note]:
this function works normal on latest firefox os build of flame v2.5 & aries v2.5

Comment 1

[Verson Xiong (Leave from Mozilla)]

Attachment: Arieskk.3gp

Comment 2

[[:fabrice] Fabrice Desré]

Attachment: b2gdroid-ua.patch

On b2gdroid, we want to get the same UA string as Firefox OS, but we run with the android widgetry. That means that even with MOZ_UA_OS_AGNOSTIC set, we were adding the platform version to the platform token, which is just wrong, and the cause of youtube confusion. We keep setting mCompatDevice as before.

Comment 3

[Gervase Markham [:gerv]]

Comment on attachment 8681577 [details] [diff] [review]
b2gdroid-ua.patch

Review of attachment 8681577 [details] [diff] [review]:
-----------------------------------------------------------------

Isn't this going to try and stick an Android version string into the UA of _every_ OS except Firefox OS?

Gerv

Comment 4

[[:fabrice] Fabrice Desré]

No, because we're already in a #ifdef ANDROID + #ifdef MOZ_WIDGET_ANDROID block (ie, a gecko build running on "real" android, not gonk).

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/7f53bc2ffb2b

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7f53bc2ffb2b

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/7f53bc2ffb2b

Comment 8

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion