1220132 - disabled talos jobs should be run now that they are all green

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

right now 3 jobs are disabled:
winxp: 'd'
osx: 'd'
winxp: 's-e10s'

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

and osx g1-e10s

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: enable talos jobs on try

the builder differences:
Builders added:
+ Rev5 MacOSX Yosemite 10.10 try talos dromaeojs-e10s
+ Rev5 MacOSX Yosemite 10.10 try talos g1-e10s
+ Rev5 MacOSX Yosemite 10.10.5 try talos dromaeojs-e10s
+ Rev5 MacOSX Yosemite 10.10.5 try talos g1-e10s
+ Windows 7 32-bit try talos xperf-e10s
+ Windows XP 32-bit try talos dromaeojs


Most likely these will have quick answers and we will quickly iterate on enabling by default or disabling again.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

it appears that winxp-svgr-e10s is already enabled, the patch makes it much clearer.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

landed:
https://hg.mozilla.org/build/buildbot-configs/rev/40f5ccb364c3

callek did r+ via email (no bmo access atm)

Comment 5

[Kim Moir [:kmoir] ET]

in production

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

looking very green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=12c4214c97ef

next step would be to enable these jobs in the same pattern the other platforms are.  We do have to watch out for beta/aurora.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: enable jobs by default now that they are all green

here are the builders added:
+ Rev5 MacOSX Yosemite 10.10 fx-team talos dromaeojs-e10s
+ Rev5 MacOSX Yosemite 10.10 fx-team talos g1-e10s
+ Rev5 MacOSX Yosemite 10.10 mozilla-central talos dromaeojs-e10s
+ Rev5 MacOSX Yosemite 10.10 mozilla-central talos g1-e10s
+ Rev5 MacOSX Yosemite 10.10 mozilla-inbound talos dromaeojs-e10s
+ Rev5 MacOSX Yosemite 10.10 mozilla-inbound talos g1-e10s
+ Windows XP 32-bit alder talos dromaeojs
+ Windows XP 32-bit ash pgo talos dromaeojs
+ Windows XP 32-bit ash talos dromaeojs
+ Windows XP 32-bit cedar talos dromaeojs
+ Windows XP 32-bit fx-team pgo talos dromaeojs
+ Windows XP 32-bit fx-team talos dromaeojs
+ Windows XP 32-bit jamun talos dromaeojs
+ Windows XP 32-bit mozilla-aurora pgo talos dromaeojs
+ Windows XP 32-bit mozilla-aurora talos dromaeojs
+ Windows XP 32-bit mozilla-beta pgo talos dromaeojs
+ Windows XP 32-bit mozilla-beta talos dromaeojs
+ Windows XP 32-bit mozilla-central pgo talos dromaeojs
+ Windows XP 32-bit mozilla-central talos dromaeojs
+ Windows XP 32-bit mozilla-inbound pgo talos dromaeojs
+ Windows XP 32-bit mozilla-inbound talos dromaeojs


Only a few concerns:
* beta - older code, might not be applicable
* aurora - should have same code as uplift occurred last week, but different configs
* pgo* - didn't test pgo on try- for osx it doesn't matter, for windows it does.

Other than that, I know of no other caveats!

Comment 8

[Justin Wood (:Callek)]

Comment on attachment 8682610 [details] [diff] [review]
enable jobs by default now that they are all green

Review of attachment 8682610 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if you verify greenness of *pgo and beta/aurora. and either fix or submit a new patch to re-disable those.

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

landed:
https://hg.mozilla.org/build/buildbot-configs/rev/71d454af8ab3

Comment 10

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/71d454af8ab3

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

still waiting on aurora/beta data, but trunk looks great.  We still don't have xperf on e10s.  Let me verify aurora/beta before tackling that problem.

Comment 12

[Joel Maher ( :jmaher ) (UTC -8)]

aurora is fine!  no new data on beta;  Also we will be disabling damp on winxp due to issues with getting a large page reloaded reliably.  This is a winxp only issue.

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

mozilla-beta is all good.

Now to figure out the xperf e10s

Comment 14

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: simple talos.json fix to get xperf-e10s running (1.0)

Comment 15

[William Lachance (:wlach)]

Comment on attachment 8684400 [details] [diff] [review]
simple talos.json fix to get xperf-e10s running (1.0)

Review of attachment 8684400 [details] [diff] [review]:
-----------------------------------------------------------------

Apparently xperf.config has migrating its way into some python file in which case this change sounds fine.

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7b34dc6ef9e

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d7b34dc6ef9e

Comment 18

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: enable xperf-e10s on all integration branches (1.0)

after seeing this green on m-c, it is time to do this per change

Comment 19

[Joel Maher ( :jmaher ) (UTC -8)]

and the builders added:
Builders added:
+ Windows 7 32-bit fx-team pgo talos xperf-e10s
+ Windows 7 32-bit fx-team talos xperf-e10s
+ Windows 7 32-bit mozilla-inbound pgo talos xperf-e10s
+ Windows 7 32-bit mozilla-inbound talos xperf-e10s

Comment 20

[Justin Wood (:Callek)]

Comment on attachment 8684961 [details] [diff] [review]
enable xperf-e10s on all integration branches (1.0)

Review of attachment 8684961 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla-tests/config.py
@@ -2330,4 @@
>  BRANCHES['try']['xperf-e10s_tests'] = (1, False, TALOS_TP_NEW_OPTS, WIN7_ONLY)
>  BRANCHES['try']['dromaeojs-e10s_tests'] = (1, False, {}, ALL_TALOS_PLATFORMS)
> -BRANCHES['try']['dromaeojs_tests'] = (1, False, {}, ALL_TALOS_PLATFORMS)
> -BRANCHES['try']['g1-e10s_tests'] = (1, False, {}, ALL_TALOS_PLATFORMS)

this hunk seems unrelated...

Comment 21

[Joel Maher ( :jmaher ) (UTC -8)]

landed:
https://hg.mozilla.org/build/buildbot-configs/rev/3af2504ec4ae

thanks for pointing out the additional cleanup- it is intended and should make future editing simpler.

As far as I know, this is the last patch and when this is deployed we can close this bug for good!

Comment 22

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/f339f85d742e