1220145 - DownloadContentService: Check space on disk before downloading content

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

The catalog of downloadable content contains the byte size of items. We should check whether we have enough available disk space before downloading any content.

Comment 1

[Alex Johnson (:alex_johnson)]

Attachment: MozReview Request: Bug 1220145 - DownloadContentService: Check space on disk before downloading content. r?sebastian

Bug 1220145 - DownloadContentService: Check space on disk before downloading content. r?sebastian

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8683126 [details]
MozReview Request: Bug 1220145 - DownloadContentService: Check space on disk before downloading content. r?sebastian

https://reviewboard.mozilla.org/r/24195/#review21923

Hi Alex! Thank you for your patch. Unfortunately there has been a misunderstanding here. This bug is about adding this functionality to DownloadContentService - a new service that will be added in bug 1197720 and has not landed yet.

I assume your patch is intended to check the disk space before downloading files from the web? This is also an interesting idea and you could just file a new bug for that (I couldn't find a duplicate for that) and discuss your patch there.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Resetting assignee until we can take action here.

@Alex: You can still work on this after the service has been added in bug 1220145, if you like. However this will take some more time.

Comment 4

[Alex Johnson (:alex_johnson)]

(In reply to Sebastian Kaspari (:sebastian) from comment #3)
> Resetting assignee until we can take action here.
> 
> @Alex: You can still work on this after the service has been added in bug
> 1220145, if you like. However this will take some more time.

I would still like to work on this.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1220145 - DownloadContentService: Check space on disk before downloading content. r?rnewman

Review commit: https://reviewboard.mozilla.org/r/28703/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28703/

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Alex Johnson (:alex_johnson) from comment #4)
> (In reply to Sebastian Kaspari (:sebastian) from comment #3)
> > Resetting assignee until we can take action here.
> > 
> > @Alex: You can still work on this after the service has been added in bug
> > 1220145, if you like. However this will take some more time.
> 
> I would still like to work on this.

Sorry, for stealing this bug away. I have a bunch of patches for DownloadContentService in the making and they all build up on each other.

Comment 7

[Richard Newman [:rnewman]]

Comment on attachment 8700343 [details]
MozReview Request: Bug 1220145 - DownloadContentService: Check space on disk before downloading content. r?rnewman

https://reviewboard.mozilla.org/r/28703/#review25757

::: mobile/android/base/java/org/mozilla/gecko/dlc/DownloadAction.java:326
(Diff revision 1)
> +        if (destinationDirectory.getUsableSpace() < content.getSize() * 2) {

The Charis fonts compress down by 68% -- 1.6MB turns into 540KB. You should probably make this `* 3`.

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Richard Newman [:rnewman] from comment #7)
> The Charis fonts compress down by 68% -- 1.6MB turns into 540KB. You should
> probably make this `* 3`.

getSize() returns the uncompressed size of the content. So this should be 1.6MB * 2 = 3.2MB here. Assuming that the compressed files are always smaller we should be good.

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/ffef281f87e208e77cf5142590982c02e875767b
Bug 1220145 - DownloadContentService: Check space on disk before downloading content. r=rnewman

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ffef281f87e2