1220155 - Orange underline in first run is misplaced

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[Ioana Chiorean]

Attachment: FirstRUNBUG.jpg

Device: Nexus 5, x86, HTC Desire HD
Android: 2.3, 6.0, 4.0.4, 
Aurora 44.0a2 (2015-10-30)

Steps to reproduce:
1. Open the app after fresh install or after cleaning data from android settings
2. switch from Import tab to Switch and back
3. Switch from portrait to landscape 

Expected Result:
- the orange underline is under the current tab only 

Actual Result:
- the line is misplaced on 2.3 when u switch as at point 2 and for the rest of devices when doing step 3

Comment 1

[:Margaret Leibovic]

Chenxia, have you seen this?

Comment 2

[Chenxia Liu [:liuche]]

This is a problem with our TabStripLayout - we don't account for layout changes. We should consider using Android's TabLayout, which it looks like we decided not to use initially due to apk size. This would also fix the highlight problem in bug 1218498.

I don't have time for this right now, and we would need to verify that the library doesn't add to much (we can remove all our TabStripLayout code) and that it can still do all the things that we need it to (which is mainly just setting the highlight color), but we've done this before with RecyclerView, and I have a patch for doing this with CardView in bug 1203730.

Comment 3

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Margaret, looking at the attached jpeg, this bug seems bad. Do you think we could get a fix soon so this is fixed early on in the Aurora44 cycle? We will push 44 on Aurora channel (most likely) on Tuesday 11/3.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Chenxia Liu [:liuche] from comment #2)
> I don't have time for this right now, and we would need to verify that the
> library doesn't add to much (we can remove all our TabStripLayout code) and
> that it can still do all the things that we need it to (which is mainly just
> setting the highlight color), but we've done this before with RecyclerView,
> and I have a patch for doing this with CardView in bug 1203730.

The Android design library (including TabLayout) is already part of the build. :)

Comment 5

[:Margaret Leibovic]

(In reply to Ritu Kothari (:ritu) on PTO Oct26-30 from comment #3)
> Margaret, looking at the attached jpeg, this bug seems bad. Do you think we
> could get a fix soon so this is fixed early on in the Aurora44 cycle? We
> will push 44 on Aurora channel (most likely) on Tuesday 11/3.

Chenxia, what do you think? I feel like replacing the implementation with TabLayout would be a non-trivial thing to uplift.

Perhaps we should just dismiss the first run experience if the orientation changes? Or forcibly re-display it?

I wouldn't normally be too worried about an edge case like this, but I don't want us to look unpolished on first run.

Comment 6

[Ioana Chiorean]

Attachment: first run.jpg

All tabs are aligned to left side - latest Beta build - even when there is only one. As per IRC discussion this goes under the same issue presented here.

Comment 7

[Chenxia Liu [:liuche]]

Trying to fix these problems by switching away from our patchy TabMenuStripLayout and using the Android design library TabLayout, because we should stop investing in our homegrown version that we wrote when the design library wasn't available. I'm going to dupe this and that should track those problems now.

Comment 8

[Chenxia Liu [:liuche]]

Actually let's add that as a dependency.

Comment 9

[:Margaret Leibovic]

We can resolve this as INVALID now, right?

Comment 10

[Chenxia Liu [:liuche]]

We've changed the way the firstrun panels are laid out, so this bug no longer applies.