1220172 - Should hide platform allocations

Status: NEW

(DevTools :: Memory, defect, P2)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: Screen Shot 2015-10-30 at 8.15.05 AM.png

We currently display some platform allocations in the census:

setTimeout_timerTimer.jsm:30:5
MessageQueue.push/this._timeout<content-sessionStore.js:633:40

We should hide this unless show platform data is on. Right now, the pref is `devtools.performance.ui.show-platform-data`, but we should probably move this under `devtools.` as many tools could use this.

We should not attempt to handle this for Fx44.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Jordan, do you have STR?

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

We should only do this for tab/worker targets, not addons or the full process.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

STR
* Go to http://news.ycombinator.com
* Open memory tools, turn on recording allocation stack
* Refresh
* Take snapshot
* Go to allocation stack view
* Should get some chrome JS listed:

makeInfallible/<DevToolsUtils.js:87:14gre
PageStyleHandler.init/<tab-content.js:435:40browser
this.ContentLinkHandler.init/<ContentLinkHandler.jsm:31:7
ContentPolicyChild.shouldLoadRemoteAddonsChild.jsm:183:31gre


----

In addon debugging or full process debugging, 'show platform data' is on by default

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Run Ublock, and you'll see entries from it via "frameModule.js" from chrome://ublock0/content/frameModule.js

This should pertain to all views, not just census/aggregate views. Hiding it would be disengenious; maybe dim it out like we do when showing platform data in the profiler?