Closed
Bug 1220193
Opened 9 years ago
Closed 9 years ago
toolkit/themes/windows/mozapps/jar.mn should use 2 space indentation
Categories
(Toolkit :: Themes, defect)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla45
People
(Reporter: ntim, Assigned: hanue, Mentored)
Details
(Whiteboard: [good first bug])
Attachments
(1 file, 1 obsolete file)
12.81 KB,
patch
|
ntim
:
review+
dao
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•9 years ago
|
Mentor: ntim.bugs
Whiteboard: [good first bug]
Assignee | ||
Comment 1•9 years ago
|
||
Hello. Please find attached my patch.
Attachment #8681644 -
Flags: review?(ntim.bugs)
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → hanue
Status: NEW → ASSIGNED
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8681644 [details] [diff] [review]
rev1 - Indentation changes
Review of attachment 8681644 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks the patch ! The patch looks good, but it seems like it is based on an older version of the source code. Can you pull down the latest source code and make your next patch on top of it ?
Attachment #8681644 -
Flags: review?(ntim.bugs) → feedback+
Assignee | ||
Comment 3•9 years ago
|
||
Hello Tim! Could you please tell me if there is an easy way of doing this or do I have to delete my whole source code and re-download it?
Assignee | ||
Comment 4•9 years ago
|
||
Played with a couple of commands, I am now using hg pull. This is probably what I was after. Need to wait a while for the source code to download.
Reporter | ||
Comment 5•9 years ago
|
||
(In reply to Eduard Hanu from comment #4)
> Played with a couple of commands, I am now using hg pull. This is probably
> what I was after. Need to wait a while for the source code to download.
Yep, hg pull is the right command. I usually do hg pull -u so 'hg update' automatically starts after hg pull, but it's fine if you don't use the -u parameter, you can still manually do hg update.
Btw, make you unapply all of your patches before you starting pulling.
Assignee | ||
Comment 6•9 years ago
|
||
I have redone my patch using the latest source code.
Attachment #8681687 -
Flags: review?(ntim.bugs)
Reporter | ||
Comment 7•9 years ago
|
||
Comment on attachment 8681687 [details] [diff] [review]
rev2 - Indentation changes
Review of attachment 8681687 [details] [diff] [review]:
-----------------------------------------------------------------
This patch looks good to me, although this needs peer review (I'm not one).
Attachment #8681687 -
Flags: review?(ntim.bugs)
Attachment #8681687 -
Flags: review?(dao)
Attachment #8681687 -
Flags: review+
Reporter | ||
Updated•9 years ago
|
Attachment #8681644 -
Attachment is obsolete: true
Updated•9 years ago
|
Attachment #8681687 -
Flags: review?(dao) → review+
Comment 9•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment 10•9 years ago
|
||
bugherder uplift |
status-b2g-v2.5:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•