toolkit/themes/windows/mozapps/jar.mn should use 2 space indentation

RESOLVED FIXED in Firefox 45, Firefox OS v2.5

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ntim, Assigned: hanue, Mentored)

Tracking

unspecified
mozilla45
Points:
---

Firefox Tracking Flags

(firefox45 fixed, b2g-v2.5 fixed)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
Mentor: ntim.bugs
Whiteboard: [good first bug]
(Assignee)

Comment 1

3 years ago
Created attachment 8681644 [details] [diff] [review]
rev1 - Indentation changes

Hello. Please find attached my patch.
Attachment #8681644 - Flags: review?(ntim.bugs)
Assignee: nobody → hanue
Status: NEW → ASSIGNED
Comment on attachment 8681644 [details] [diff] [review]
rev1 - Indentation changes

Review of attachment 8681644 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks the patch ! The patch looks good, but it seems like it is based on an older version of the source code. Can you pull down the latest source code and make your next patch on top of it ?
Attachment #8681644 - Flags: review?(ntim.bugs) → feedback+
(Assignee)

Comment 3

3 years ago
Hello Tim! Could you please tell me if there is an easy way of doing this or do I have to delete my whole source code and re-download it?
(Assignee)

Comment 4

3 years ago
Played with a couple of commands, I am now using hg pull. This is probably what I was after. Need to wait a while for the source code to download.
(In reply to Eduard Hanu from comment #4)
> Played with a couple of commands, I am now using hg pull. This is probably
> what I was after. Need to wait a while for the source code to download.

Yep, hg pull is the right command. I usually do hg pull -u so 'hg update' automatically starts after hg pull, but it's fine if you don't use the -u parameter, you can still manually do hg update.
Btw, make you unapply all of your patches before you starting pulling.
(Assignee)

Comment 6

3 years ago
Created attachment 8681687 [details] [diff] [review]
rev2 - Indentation changes

I have redone my patch using the latest source code.
Attachment #8681687 - Flags: review?(ntim.bugs)
Comment on attachment 8681687 [details] [diff] [review]
rev2 - Indentation changes

Review of attachment 8681687 [details] [diff] [review]:
-----------------------------------------------------------------

This patch looks good to me, although this needs peer review (I'm not one).
Attachment #8681687 - Flags: review?(ntim.bugs)
Attachment #8681687 - Flags: review?(dao)
Attachment #8681687 - Flags: review+
Attachment #8681644 - Attachment is obsolete: true

Updated

3 years ago
Attachment #8681687 - Flags: review?(dao) → review+

Comment 9

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bcf186f84c36
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.