1220245 - Awkward spacing on FTU About/Telemetry screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P3)

Description

[Sam Foster [:sfoster] (he/him)]

Attachment: ftu-telemetry-logo-master.png

The logo is left-aligned and introductory paragraph seems cramped. Not sure if this was deliberate in an attempt to get everything above the fold, but as that will vary hugely in different languages I think we should just fix it and let it take the height it needs.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: ftu-telemetry-logo-patched.png

Proposed fix - centers the logo, adds 2rem padding between it and the intro paragraph.

Comment 2

[Eric Pang [:epang] UX]

Comment on attachment 8681420 [details]
ftu-telemetry-logo-patched.png

Looks good, thanks Sam!

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] sfoster:ftu-2-5-videos-bug-1212961 > mozilla-b2g:master

Comment 4

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8681489 [details] [review]
[gaia] sfoster:ftu-2-5-videos-bug-1212961 > mozilla-b2g:master

Grr, got attached to wrong bug.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] sfoster:ftu-telemetry-layout-bug-1220245 > mozilla-b2g:master

Comment 6

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8681494 [details] [review]
[gaia] sfoster:ftu-telemetry-layout-bug-1220245 > mozilla-b2g:master

r=me for trivial, well-scoped FTU CSS change that has ui-review+

Comment 7

[Sam Foster [:sfoster] (he/him)]

Merged to master: https://github.com/mozilla-b2g/gaia/commit/b4f8752dea2d8d5d8cb8abbd7f3ab0b2c619a9c9

Comment 8

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8681494 [details] [review]
[gaia] sfoster:ftu-telemetry-layout-bug-1220245 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): This screen was re-designed for 2.5
[User impact] if declined: Mis-aligned/cramped text on FTU telemetry screen
[Testing completed]: Verified on device
[Risk to taking this patch] (and alternatives if risky): V low risk, polish bug with FTU and screen-specific CSS changes
[String changes made]: none

Comment 9

[Jessica]

Attachment: verified_Aries KK v2.6.png

According to the STR of Comment 0, this bug has been verified as pass on latest Flame KK v2.5 & v2.6, and Aries KK v2.6.

Actual results: The logo is left-aligned and introductory paragraph seems normally.
See attachment: verified_Aries KK v2.6.png
Reproduce rate: 0/6

Device: Flame KK v2.5 512mb (Pass)
Build ID               20151103004501
Gaia Revision          91cac94948094cfdcd00cba5c6483e27e80cb3b0
Gaia Date              2015-10-28 20:32:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4e0955369a51850f2982087145ac5c2df257ffe9
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151103.054921
Firmware Date          Tue Nov  3 05:49:36 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK v2.6 512mb (master) (Pass)
Build ID               20151103150203
Gaia Revision          61918ddd9ccce104c009e873e34a0791e125753a
Gaia Date              2015-11-03 17:22:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f742b9412ed5aace90ad863b276faae0641090a8
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151103.182550
Firmware Date          Tue Nov  3 18:26:03 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK v2.6 (master) (Pass)
Build ID               20151104004249
Gaia Revision          61918ddd9ccce104c009e873e34a0791e125753a
Gaia Date              2015-11-03 17:22:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f742b9412ed5aace90ad863b276faae0641090a8
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151104.000116
Firmware Date          Wed Nov  4 00:01:24 UTC 2015
Bootloader             s1

Comment 10

[Mahendra Potharaju [:mahe]]

Comment on attachment 8681494 [details] [review]
[gaia] sfoster:ftu-telemetry-layout-bug-1220245 > mozilla-b2g:master

This landed in 2.5. Updating approval flag

Thanks