Remove explicit use of AppCompatCheckBox

RESOLVED FIXED in Firefox 53

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
8 months ago

People

(Reporter: mcomella, Assigned: Owais Kazi, Mentored)

Tracking

unspecified
Firefox 53
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [lang=java][good next bug])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Added as a work-around fix in bug 1220196, waiting on bug 1220309.
(Reporter)

Comment 1

a year ago
These files can be found at:
  https://mxr.mozilla.org/mozilla-central/search?string=appcompatcheckbox&find=mobile%2Fandroid&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

I think using <CheckBox (or whatever) directly should just work.
Mentor: michael.l.comella@gmail.com
Whiteboard: [lang=java][good next bug]

Updated

a year ago
Assignee: nobody → maurya1985

Updated

a year ago
Assignee: maurya1985 → nobody

Comment 2

a year ago
I would like to work on this bug but the link to the files doesn't seem to work. I'm assuming that the only AppCompatCheckBox that needs changing is in PromptInput.java. Is that correct?
(Reporter)

Comment 3

a year ago
(In reply to Kevin Lam from comment #2)
> I would like to work on this bug but the link to the files doesn't seem to
> work. I'm assuming that the only AppCompatCheckBox that needs changing is in
> PromptInput.java. Is that correct?

It's entirely possible that my initial hypothesis, that bug 1220309 would fix the issue, is incorrect.

That being said, I don't think you should change the PromptInput value. afaik, the XML is changed to dynamically change CheckBox -> AppCompatCheckBox, but references in code are not updated. See here for a list of all uses of AppCompatCheckBox:
  https://dxr.mozilla.org/mozilla-central/search?q=path%3Amobile%2Fandroid+AppCompatCheck&redirect=false
(Assignee)

Comment 4

9 months ago
Created attachment 8816767 [details]
Changed AppCombatCheckBox to CheckBox and build successfully
(Assignee)

Comment 5

9 months ago
Hi Michael!
Have a look at the attachment 8816767 [details] and if it is fine then i will upload a patch soon.
(Reporter)

Comment 6

9 months ago
Hi, Owais. I'm no longer working on Fennec – let me see if I can get someone else to help you.

Sebastian, could you take a look at this or redirect it? Thanks!
Mentor: s.kaspari@gmail.com
Flags: needinfo?(s.kaspari)
(Assignee)

Comment 7

8 months ago
Hi sebastian!
https://reviewboard-hg.mozilla.org/gecko/rev/99b97f682498 Please review my code
(Assignee)

Comment 8

8 months ago
Can you please assign this bug to me?
Assignee: nobody → owaiskazi19
Status: NEW → ASSIGNED
(Assignee)

Comment 9

8 months ago
Hi sebastian!
Please review my patch
This patch seems to have the wrong format.

The following guide should help you to submit a patch to mozreview and link it with this bug:
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html
Flags: needinfo?(s.kaspari) → needinfo?(owaiskazi19)
(In reply to Owais Kazi from comment #7)
> Hi sebastian!
> https://reviewboard-hg.mozilla.org/gecko/rev/99b97f682498 Please review my
> code

It looks like you pushed the patch but it wasn't linked to this bug. Just include the bug number and push again: "Bug XXXXX - Commit message. r?sebastian".
Comment hidden (mozreview-request)

Comment 13

8 months ago
mozreview-review
Comment on attachment 8819347 [details]
Bug 1220316-Removed explicit use of AppCompactCheckBox in the following files Part 2. .

https://reviewboard.mozilla.org/r/99168/#review99452
Attachment #8819347 - Flags: review?(s.kaspari) → review+
(Assignee)

Comment 14

8 months ago
I got this error in 'try' http://mibpaste.com/XhuPko. Can you help me with it?
(Assignee)

Comment 15

8 months ago
Is this bug completed https://treeherder.mozilla.org/#/jobs?repo=try&revision=92f61c240cef or it does have error?
(Assignee)

Updated

8 months ago
Keywords: checkin-needed

Comment 16

8 months ago
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7be572e3697d
Removed explicit use of AppCompactCheckBox in the following files Part 2. r=sebastian.
Keywords: checkin-needed
(Assignee)

Updated

8 months ago
Flags: needinfo?(owaiskazi19)
(Assignee)

Comment 17

8 months ago
Is this bug fixed now?
Flags: needinfo?(s.kaspari)
(In reply to Owais Kazi from comment #17)
> Is this bug fixed now?

Yes, as soon as the patch is merged to mozilla-central this bug will be closed.
Flags: needinfo?(s.kaspari)

Comment 19

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7be572e3697d
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.