1220316 - Remove explicit use of AppCompatCheckBox

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Added as a work-around fix in bug 1220196, waiting on bug 1220309.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

These files can be found at:
  https://mxr.mozilla.org/mozilla-central/search?string=appcompatcheckbox&find=mobile%2Fandroid&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

I think using <CheckBox (or whatever) directly should just work.

Comment 2

[Kevin Lam]

I would like to work on this bug but the link to the files doesn't seem to work. I'm assuming that the only AppCompatCheckBox that needs changing is in PromptInput.java. Is that correct?

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Kevin Lam from comment #2)
> I would like to work on this bug but the link to the files doesn't seem to
> work. I'm assuming that the only AppCompatCheckBox that needs changing is in
> PromptInput.java. Is that correct?

It's entirely possible that my initial hypothesis, that bug 1220309 would fix the issue, is incorrect.

That being said, I don't think you should change the PromptInput value. afaik, the XML is changed to dynamically change CheckBox -> AppCompatCheckBox, but references in code are not updated. See here for a list of all uses of AppCompatCheckBox:
  https://dxr.mozilla.org/mozilla-central/search?q=path%3Amobile%2Fandroid+AppCompatCheck&redirect=false

Comment 4

[Owais Kazi]

Attachment: Changed AppCombatCheckBox to CheckBox and build successfully

Comment 5

[Owais Kazi]

Hi Michael!
Have a look at the attachment 8816767 [details] and if it is fine then i will upload a patch soon.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Hi, Owais. I'm no longer working on Fennec – let me see if I can get someone else to help you.

Sebastian, could you take a look at this or redirect it? Thanks!

Comment 7

[Owais Kazi]

Hi sebastian!
https://reviewboard-hg.mozilla.org/gecko/rev/99b97f682498 Please review my code

Comment 8

[Owais Kazi]

Can you please assign this bug to me?

Comment 9

[Owais Kazi]

Hi sebastian!
Please review my patch

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

This patch seems to have the wrong format.

The following guide should help you to submit a patch to mozreview and link it with this bug:
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Owais Kazi from comment #7)
> Hi sebastian!
> https://reviewboard-hg.mozilla.org/gecko/rev/99b97f682498 Please review my
> code

It looks like you pushed the patch but it wasn't linked to this bug. Just include the bug number and push again: "Bug XXXXX - Commit message. r?sebastian".

Comment 12

[Owais Kazi]

Attachment: Bug 1220316-Removed explicit use of AppCompactCheckBox in the following files Part 2. .

Review commit: https://reviewboard.mozilla.org/r/99168/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99168/

Comment 13

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8819347 [details]
Bug 1220316-Removed explicit use of AppCompactCheckBox in the following files Part 2. .

https://reviewboard.mozilla.org/r/99168/#review99452

Comment 14

[Owais Kazi]

I got this error in 'try' http://mibpaste.com/XhuPko. Can you help me with it?

Comment 15

[Owais Kazi]

Is this bug completed https://treeherder.mozilla.org/#/jobs?repo=try&revision=92f61c240cef or it does have error?

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7be572e3697d
Removed explicit use of AppCompactCheckBox in the following files Part 2. r=sebastian.

Comment 17

[Owais Kazi]

Is this bug fixed now?

Comment 18

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Owais Kazi from comment #17)
> Is this bug fixed now?

Yes, as soon as the patch is merged to mozilla-central this bug will be closed.

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7be572e3697d