Closed
Bug 1220358
Opened 9 years ago
Closed 9 years ago
Fix -Wunreachable-code warnings in widget/cocoa
Categories
(Core :: Widget: Cocoa, defect)
Core
Widget: Cocoa
Tracking
()
RESOLVED
FIXED
mozilla45
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
|
2.51 KB,
patch
|
spohl
:
review+
|
Details | Diff | Splinter Review |
clang's -Wunreachable-code warnings are not enabled by default, but we're getting close to being able to enable them in mozilla-central.
widget/cocoa/nsNativeThemeCocoa.mm:3774:7 [-Wunreachable-code-break] 'break' will never be executed
widget/cocoa/nsNativeThemeCocoa.mm:3790:7 [-Wunreachable-code-break] 'break' will never be executed
widget/cocoa/nsNativeThemeCocoa.mm:3818:5 [-Wunreachable-code-break] 'break' will never be executed
Attachment #8681591 -
Flags: review?(spohl.mozilla.bugs)
|
||
Updated•9 years ago
|
Attachment #8681591 -
Flags: review?(spohl.mozilla.bugs) → review+
|
||
Comment 2•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
|
|
||
Comment 3•9 years ago
|
||
| bugherder uplift | ||
status-b2g-v2.5:
--- → fixed
|
Assignee | |
Updated•9 years ago
|
Blocks: Wunreachable-code
You need to log in
before you can comment on or make changes to this bug.
Description
•