1220376 - Fix formatted string for Child Payload N in about:telemetry

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Chris H-C :chutten]

In adding child payloads to about:telemetry I wrote a formatted string with %1$s instead of %1$S (note the case). The former only supports one character, so it will only work until pings start to have more than nine child payloads.

Comment 1

[Chris H-C :chutten]

Attachment: 0001-Bug-1220376-Use-1-S-instead-of-1-s.-r-gfritzsche.patch

Comment 2

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8681962 [details] [diff] [review]
0001-Bug-1220376-Use-1-S-instead-of-1-s.-r-gfritzsche.patch

Review of attachment 8681962 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/locales/en-US/chrome/global/aboutTelemetry.properties
@@ +73,5 @@
>  parentPayload = Parent Payload
>  
>  # Note to translators:
> +# - The %1$S will be replaced with the number of the child payload (e.g. "1", "2")
> +childPayloadN = Child Payload %1$S

Common practice is apparently to add a ".<Number>" suffix, i.e. "childPayload.2".

Comment 3

[Francesco Lodolo [:flod]]

As long as the key changes it's fine, no need for versioned keys (they usually do because there's no need to think about a new name).

Comment 4

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8681962 [details] [diff] [review]
0001-Bug-1220376-Use-1-S-instead-of-1-s.-r-gfritzsche.patch

Review of attachment 8681962 [details] [diff] [review]:
-----------------------------------------------------------------

Alright, i don't have strong opinions here then.

Comment 5

[Chris H-C :chutten]

No tryserver because, as mentioned in bug 1163971, there are no tests covering this.

Adding to bug 1163971's manual tests, I have also:
  -faked having more than 10 child payloads to ensure the localization format supports more than one character.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d064c8129bcf

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d064c8129bcf

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/d064c8129bcf