1220417 - Crash when using clients.openWindow

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Marco Castelluccio [:marco]]

I have the following code in my service worker:

self.addEventListener('notificationclick', function(event) {
  event.waitUntil(clients.matchAll().then(function(clientList) {
    if (clientList.length > 0) {
      return clientList[0].focus();
    } else {
      return clients.openWindow('index.html');
    }
  }));
});

If a client tab is opened and I click on the notification, the client tab is successfully focused.
If there's no client tab open and I click on the notification, the content process crashes.

Comment 1

[Marco Castelluccio [:marco]]

https://crash-stats.mozilla.com/report/index/20349a1a-000f-4fff-ac3d-f262e2151031
https://crash-stats.mozilla.com/report/index/cd61110c-f1e1-4448-a60b-ba6d42151031

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Catalin, any thoughts on this?

Comment 3

[Cătălin Badea (:catalinb)]

Yes, this was introduced in bug 1191724. I fixed the crash when I relanded patch 3 from 1172870, but it wasn't merged to m-c yet.

https://hg.mozilla.org/integration/mozilla-inbound/rev/89c9c63c7654

Comment 4

[Marco Castelluccio [:marco]]

Thanks, it's working now.