1220457 - Show deprecation warning for non-standard RegExp.multiline.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tooru Fujisawa [:arai]]

Derived from bug 1219757.

bug 1219757 is going to remove non-standard RegExp.multiline.  It should be better to show warning message for some cycles.
It won't be used in web content as it's non-standard.  also, it's rarely used in add-ons in AMO, so I guess it's also rarely used in non-AMO add-ons.  So telemetry could be an overkill.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Show deprecation warning for non-standard RegExp.multiline.

Added warning for setting and getting RegExp.multiline (but warn only once per compartment)

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8691859 [details] [diff] [review]
Show deprecation warning for non-standard RegExp.multiline.

Review of attachment 8691859 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you, r=me with nit addressed.

::: js/src/builtin/RegExp.cpp
@@ +652,5 @@
> +{
> +    if (!cx->compartment()->warnedAboutRegExpMultiline) {
> +        if (!JS_ReportErrorFlagsAndNumber(cx, JSREPORT_WARNING, GetErrorMessage, nullptr,
> +                                          JSMSG_DEPRECATED_REGEXP_MULTILINE))
> +            return false;

Nit: braces required because of the multi-line condition.

Comment 3

[Tooru Fujisawa [:arai]]

Thanks!

as discussed in IRC, this patch should *not* be landed to firefox45, to avoid showing warning for enigmail in Thunderbird45.
I will land it after next aurora merge (so firefox46).

Comment 4

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5ac90824efedaa33efdce5acc42d61fa0bdb7dc8
Bug 1220457 - Show deprecation warning for non-standard RegExp.multiline. r=till

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5ac90824efed

Comment 6

[Kohei Yoshino]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-US/docs/2015/regexp-multiline-global-switch-has-been-deprecated/