1220462 - In this official Git tutorial page, some text is not rendered ok

Status: RESOLVED INVALID

(Web Compatibility :: Site Reports, defect, P3)

Description

[Kostas]

To reproduce (using Firefox Nightly x64 30-10-2015, in win 10x64)

- open: https://try.github.io/levels/1/challenges/9
- click on the 'git log' text (in order that text to be "typed" on the TryGit "window" below)
and then press 'Enter'
Here is how it's rendered: https://i.imgur.com/2AVKaJp.jpg
i.e. "symbols" characters + non-bold text


For reference:
- Here is how it's rendered on Firefox 41.0.2 stable: https://i.imgur.com/EpGAw39.jpg
i.e. no "symbols" characters but still non-bold text

- And here in Chrome 46 stable, https://i.imgur.com/dOxaSw3.jpg
i.e. no "symbols" characters, bold text, -as expected-

Comment 1

[Alice0775 White]

Maybe due to [url=https://bugzilla.mozilla.org/show_bug.cgi?id=1099557]#1099557[/url] [Core:Layout: Text]-spurious control characters within content should be rendered as hexboxes, not hidden (reverting the behavior change from bug 947588) [All]

Setting layout.css.control-characters.visible = false revert to old behavior.

Comment 2

[Kostas]

I've deleted the 1st screenshot because a linkification userscript was enabled by mistake when I took the screenshot, that's why the two (linkified) email addresses had blue color - sorry.
The correct one is: https://i.imgur.com/AfkWojf.jpg

Comment 3

[Paul Silaghi, QA [:pauly]]

Confirmed the issue on 45.0a1 (2015-12-07) Win 7

Comment 4

[Jonathan Kew [:jfkthame]]

I think this is a bug in the try.github.io site; it's including <ESC> (0x1b) codepoints surrounding the commit ID line, which it shouldn't.

(My guess is that these result from ANSI escape sequences that "git log" emits to color the line; then try.github.io aims to recognize these and turn them into markup and styling (a colored <span>), but it incorrectly leaves the leading <ESC> of each control sequence in the text instead of removing it along with the rest of the terminal controls.)

Comment 5

[Boris Zbarsky [:bzbarsky]]

We should probably contact the site, then...

Comment 6

[Mike Taylor [:miketaylr]]

Yep, let's do that. Ideally once we know when Blink is shipping this, we can contact sites and they'll be more motivated to make a fix.

Comment 7

[Adam Stevenson [:adamopenweb]]

Looks like the website has changed / removed. Let's close this report as invalid.