Closed Bug 1220524 Opened 5 years ago Closed 4 years ago

wrap match_pattern as AMD module

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(tracking-b2g:backlog)

RESOLVED FIXED
2.6 S1 - 11/20
tracking-b2g backlog

People

(Reporter: gasolin, Assigned: rakhavan)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file, 1 obsolete file)

followup of bug 1216446

We should avoid introduce more js when its only used in sub panel
Depends on: 1216446
The patch looks good. Thanks for doing this. I tested locally and the new dialog warning is still working, but I was unable to confirm that I saw the toaster from the settings app when disabling/un-installing an addon that affects the system.

I'm not sure if it's related, but GU13 is failing:
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=7c22667f7e89f91030749951d2906856967e2510
Yeah I have not figure out why require('shared/addons/match_pattern') not properly required in addon_manager_test (which leads test fail).

Feel free to take it over, finish it and set review to me.
Assignee: nobody → rakhavan
Target Milestone: --- → 2.6 S1 - 11/20
Whiteboard: [systemsfe]
Attachment #8681787 - Attachment is obsolete: true
Comment on attachment 8686837 [details] [review]
[gaia] jedireza:wrap-match-pattern-as-amd > mozilla-b2g:master

Fred, you were really close ;)

Tests are all green:
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=c50abcb6236a5e559d3f40d3b39380b3a85fc9d8
Attachment #8686837 - Flags: review?(gasolin)
Comment on attachment 8686837 [details] [review]
[gaia] jedireza:wrap-match-pattern-as-amd > mozilla-b2g:master

thanks!
Attachment #8686837 - Flags: review?(gasolin) → review+
On master:
https://github.com/mozilla-b2g/gaia/commit/c72f21c47ee5fadf03807213f20b7e4af3b00fba
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.