1220524 - wrap match_pattern as AMD module

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

followup of bug 1216446

We should avoid introduce more js when its only used in sub panel

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1220524 > mozilla-b2g:master

Comment 2

[Reza Akhavan [:jedireza]]

The patch looks good. Thanks for doing this. I tested locally and the new dialog warning is still working, but I was unable to confirm that I saw the toaster from the settings app when disabling/un-installing an addon that affects the system.

I'm not sure if it's related, but GU13 is failing:
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=7c22667f7e89f91030749951d2906856967e2510

Comment 3

[[e-mail]]

Yeah I have not figure out why require('shared/addons/match_pattern') not properly required in addon_manager_test (which leads test fail).

Feel free to take it over, finish it and set review to me.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] jedireza:wrap-match-pattern-as-amd > mozilla-b2g:master

Comment 5

[Reza Akhavan [:jedireza]]

Comment on attachment 8686837 [details] [review]
[gaia] jedireza:wrap-match-pattern-as-amd > mozilla-b2g:master

Fred, you were really close ;)

Tests are all green:
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=c50abcb6236a5e559d3f40d3b39380b3a85fc9d8

Comment 6

[[e-mail]]

Comment on attachment 8686837 [details] [review]
[gaia] jedireza:wrap-match-pattern-as-amd > mozilla-b2g:master

thanks!

Comment 7

[Reza Akhavan [:jedireza]]

On master:
https://github.com/mozilla-b2g/gaia/commit/c72f21c47ee5fadf03807213f20b7e4af3b00fba